Shannon Kularathna

Results 12 comments of Shannon Kularathna

Since the defaults are deprecated anyway, isn't this loss of functionality more of an incentive to move off relying on just the defaults, and instead specifying explicit endpoints? Idk, someone...

I'm not sure why that hasn't happened. Maybe a deprecation policy thing? I guess a middle ground could be to move dockershim.sock to last on the list so that it...

Is it that the defaults currently do not work? I thought the case is that the defaults are deprecated and will be removed at some point, but still work for...

@SergeyKanzhelev and @afbjorklund in this case, should we leave dockershim.sock in the list of fallback options? If we keep it, we should mention in the docs that the endpoint won't...

@afbjorklund I'm honestly not sure about the versioning thing, sorry. I'd assume if we left the list of fallback endpoints as-is, the behaviour wouldn't change, but I'm not positive. Maybe...

I made a few changes @afbjorklund and @SergeyKanzhelev: * Add dockershim.sock as the last item in the list of "default" endpoints * In the docs, position setting the endpoint manually...

Lol it was not moved again, I just apparently had a brain fart. Thank you. That's also why I am trying to change the wording to be more "the fallback...

IDK why VS Code is adding the extra line 1 in main_unix.go and main_windows.go (//go:build !windows). Will it affect the file? I can't save the file without it being auto...

That's also an option. My concern comes from us having notes and warnings saying that the endpoints are deprecated. Wouldn't an automatic script continue to work if we gated the...

Thanks Natali, added. @divya-mohan0209 @sftim for the k8s.dev one, I was looking at that and it didn't seem like we had a "guidelines for PR reviews" type document there. That's...