shaneasd comments

Results 42 comments of


                                            shaneasd

Fix confusion between function call and variable declaration

@danmar could I get some input on this please?

Spin lock on volatile variable without an explicit barrier is extremely unsafe

Regarding this comment > You are absolutely right that volatile memory operations do not guarantee thread safety on all platforms. However, in this particular context, I don't think there is...

Should narrowing do something special for integer types (was: Should narrowing failures throw)

Regarding bugs vs recoverable errors: If my software has a bug that I don't know about and my end user encounters, how do I debug it? If narrow_cast throws an...

Should narrowing do something special for integer types (was: Should narrowing failures throw)

Edit: Corrected underflow vs overflow nomenclature. Thanks johnmcfarlane with regard to "the same category of information loss" that seems like a somewhat arbitrary categorization to me. The current meaning of...

Should narrowing do something special for integer types (was: Should narrowing failures throw)

Good point. I agree that loss of precision is often fine while overflow is usually not so the distinction is meaningful. To separate out these concerns it seems like a...

Should narrowing do something special for integer types (was: Should narrowing failures throw)

Just to make sure my meaning is clear, I'm not suggesting defining ```narrow_cast_fail_on_precision_loss``` as ```gsl::narrow(std::trunc(somefloat))```. I'm asserting that a user of ```gsl::narrow``` that cares about overflow error but does not...

PxJoint::getRelativeAngularVelocity error

@kstorey-nvidia it doesn't seem like this issue has been resolved in PhysX 5. Has it slipped through the cracks or is it simply a question of prioritization? Would it be...

PxJoint::getRelativeAngularVelocity error

Thanks for the update!

gsl not_null throw exception

Related: #1561

removed unused `Token::until()` and `tokenrange.h`

That change is a prerequisite for #3014. Since #3014 has seen no activity on the code review in a year I think it's probably fair to say it's not going...