MyJailbreak icon indicating copy to clipboard operation
MyJailbreak copied to clipboard

Memory leak

Open shanapu opened this issue 5 years ago • 8 comments

Creating Handles without deleting. Maybe also on other spots... make own tests with sm_dump_handles

https://forums.alliedmods.net/showpost.php?p=2633463&postcount=27

shanapu avatar Jan 07 '19 17:01 shanapu

https://github.com/shanapu/MyJailbreak/blob/dev/addons/sourcemod/scripting/MyJailbreak/weapons.sp#L296-L299 this need to be closed first before of create more and more menus.

Franc1sco avatar Jan 07 '19 23:01 Franc1sco

screenshot_1

weapons.smx is in the top5 plugins with highest memory size

nanociaglia avatar Jan 08 '19 00:01 nanociaglia

I fixed it here https://github.com/shanapu/MyJailbreak/pull/333

Franc1sco avatar Jan 08 '19 11:01 Franc1sco

After more than ~50 map changes: image

Seems like we should look into it, in weapons, warden and myjb core

Thanks for Bara for his help here.

EDIT 1: If we remove all the event days, the myjb leaks will "stop" so there are issues with the API, that is being called by the event days every map change.

Hexer10 avatar Jan 09 '19 21:01 Hexer10

This should be fixed with https://github.com/shanapu/MyJailbreak/commit/b2185cee9c84c689d0b1c148aae16855f452dfd7 . Please reply here if you're having further issues.

Hexer10 avatar Jan 09 '19 23:01 Hexer10

that's on dev branch

nanociaglia avatar Jan 09 '19 23:01 nanociaglia

I know, but you should be able to use it without any major issues

Hexer10 avatar Jan 09 '19 23:01 Hexer10

Thank you all guys! I have very little time lately to take care of my plugins. It's great to see you working together and solving the problem yourself.

Thank you very very much for your support!

Sharing is caring! ❤️

shanapu avatar Jan 12 '19 03:01 shanapu