HUGE inclusion of every JSON file under globalStorage\webhint.vscode-webhint\node_modules in my Gist

[CodeCharm]

🐛 Describe the bug
A clear and concise description of what the bug is. You are always welcome to check the Troubleshooting section before filing the ticket.

I have no idea how it got like this. There was no evidence from VSCode that anything was amiss. All I know is that I was checking into my gists just now and I found a very unexpected state:

Four days ago, the cloud settings Gist was updated, and it included 300 files where it normally has only about four, I think. It looks like it brought every single JSON file it could find in the path globalStorage\webhint.vscode-webhint\node_modules.

I'm bringing it here because AFAIK only this extension ever modifies this gist, and this is not something I think I could have done without knowing it.

🌴 Visual Studio Code Version : 1.41.1 🌴 Code Settings Sync Version : 3.4.3 🌴 Standard or Insiders : Standard 🌴 Portable or Installed : Installed (I think) 🌴 OSS or Official Build : Official 🌴 Operating System : Windows 10 🌴 Occurs On: 🌴 Proxy Enabled: No 🌴 Gist Id: [WILL BE PROVIDED TO INDIVIDUAL WORKING THIS ISSUE -- PLEASE CONTACT ME]

Version: 1.41.1 (user setup) Commit: 26076a4de974ead31f97692a0d32f90d735645c0 Date: 2019-12-18T14:58:56.166Z Electron: 6.1.5 Chrome: 76.0.3809.146 Node.js: 12.4.0 V8: 7.6.303.31-electron.0 OS: Windows_NT x64 10.0.18363

📰 To Reproduce Steps to reproduce the behavior:

I'm not sure I could deliberately reproduce this -- I don't recall what happened four days ago when it made this change

[CodeCharm]

FWIW it did it again just now. I had to build a WSL so that I could actually clone the repo to remove the excessive number of files because they have names that Windows won't allow. (Weird, because it only came from Windows systems originally). I then ran the Sync Update command from Code, and darn if it didn't try to do it again. Here's the log from the Code Settings Sync panel in VSCode (attached)

CODE SETTINGS SYNC UPLOAD SUMMARY.txt

[betaSavvy]

i encounter the same problem and just added package.json & package-lock.json to the "ignoreUploadFiles" in syncLocalSettings.json. Trigger an upload and it should be fine.

[CodeCharm]

I wound up having to add

"globalStorage"

to the ignoreUploadFolders setting in syncLocalSettings.json. I don't know why that folder isn't automatically part of the excluded folders.

[autoferrit]

Has this been released yet? I just had this error happen again.

[Fred-Vatin]

I disagree to exclude globalStorage by default. It can include settings not synchronized by the built-in sync settings. User can use the ignoreUploadFiles settings mention earlier on.