shamoon

In the meantime, there is this workaround: https://github.com/mozilla/pdf.js/issues/18867#issuecomment-2521875481 > 1. Add e.g. "typings": "./src/typings.d.ts" to your package.json file > 2. Create the file src/typings.d.ts containing only: type SetIterator = Iterator;

What doesn't work, the PR or the workaround? The workaround would only work (and be needed) in a project with ts < 5.6. Certainly both worked in my testing... The...

> Even downgrading ng2-pdf-veiwer should have been solved this issue. But looks like that library has been modified in such a way that it does not work for previous version...

A Stackblitz: https://stackblitz.com/edit/stackblitz-starters-pqzeyp Also: https://github.com/mozilla/pdf.js/issues/18867#issuecomment-2522687693

> Angular 17.3.0 Typescript: 5.2.2 ng2-pdf-viewer: 10.4.0 > > I saw the same issue with SetIterator. Fixed it by adding "./typings.d.ts" in tsconfig.app.json That is what I said above... https://github.com/VadimDez/ng2-pdf-viewer/issues/1164#issuecomment-2521859561...

Oh nice, I had thought that v4 would require substantive changes to the codebase but it seems the v3 changes were enough. Testing this locally things seem to work fine...

I think the author just updates it infrequently but I dunno. I don’t plan to create a fork.

I think this should do it ``` --- a/src/app/pdf-viewer/pdf-viewer.component.ts +++ b/src/app/pdf-viewer/pdf-viewer.component.ts @@ -32,7 +32,6 @@ import type { PDFViewerOptions, ZoomScale } from './typings'; -import { PDFSinglePageViewer } from 'pdfjs-dist/web/pdf_viewer.mjs'; import...

This small fix closes a 5-year-old (!) issue, would be great to merge.

@troehling I think this does need a rebase as there are conflicts (even though GH is not showing them above) ``` diff --cc src/ng-select/lib/ng-dropdown-panel.component.ts index ba54c1b,dbcae2e..0000000 --- a/src/ng-select/lib/ng-dropdown-panel.component.ts +++ b/src/ng-select/lib/ng-dropdown-panel.component.ts...