shamardy

Results 61 comments of shamardy

The following is the best technical book on the lightning network (Maybe the only one) https://github.com/lnbook/lnbook it's equivalent to the "Programming Bitcoin" book but for LN. It's not officially released...

Just opened the lightning payments PR. After the review process and merging to dev, the next step should be persisting lightning payments and channels history (closed channels) to storage (SQLite)...

After a swap P.O.C with lightning coin as taker was implemented, the next step would be to implement locktimes correctly for lightning. This will let us continue the implementation of...

> > The median_total_cltv_expiry for the maker payment will also be 264 blocks. In this case the taker swap locktime will be 22 hours. I believe this is acceptable. >...

> First, Just adding a note about this to not forget :) > The maker has to make sure that the final_cltv_expiry (last hop cltv) is less than the taker...

This is a diagram to demonstrate swap locktimes if taker is `LightningCoin` as explained in https://github.com/KomodoPlatform/atomicDEX-API/issues/1045#issuecomment-1310604403 https://github.com/KomodoPlatform/atomicDEX-API/issues/1045#issuecomment-1311755066 ![Lightning taker locktimes](https://user-images.githubusercontent.com/39480341/204060304-7eba64bf-caa2-4899-9724-037ef1f96caf.png) This is another diagram to demonstrate swap locktimes if maker...

@artemii235 In this comment, I would like to propose a solution to how **lightning taker fees** can be implemented in AtomicDEX so that we can discuss this solution before proceeding...

@smk762 after this PR https://github.com/KomodoPlatform/atomicDEX-API/pull/1592, new events that should be documented were added to `MAKER_SUCCESS_EVENTS`, `MAKER_ERROR_EVENTS`, `TAKER_SUCCESS_EVENTS`, `TAKER_ERROR_EVENTS`. These events are: - `MakerPaymentInstructionsReceived` added to `MAKER_SUCCESS_EVENTS`: This event is triggered...

These are the calls to RPC nodes that gets done before a maker order is placed if the order is between 2 ERC20 coins ``` check_balance_for_maker_swap get_sender_trade_fee 1 - make_gas_station_request...

Thank you @yurii-khi for discovering this bug. It seems that there was a decision in the past to remove fixed utxo transaction fee in favor of fixed fee per KB...