shamardy

Results 61 comments of shamardy

@onur-ozkan can you please review all the commits since the last approval of this PR?

@smk762 can you please check if your comments here https://github.com/KomodoPlatform/komodo-defi-framework/pull/1932#issuecomment-1729684767 are resolved?

Has been deprecated here https://github.com/KomodoPlatform/komodo-defi-framework/pull/2234 , we will provide a more maintainable version for the cli in the future.

@borngraced please resolve conflicts in this PR

> What effects does the DB changes have? If seed nodes don't save JSON files of swaps any more, then i can't use this on my seeds, else i will...

> and on the makers i need them to refund... i need to call this manually from time to time > ``` > ## maker > for i in `grep...

> Only if my_recent_swaps contain the error messages/events that happened during the swap It does for both v1 and v2 swaps https://komodoplatform.com/en/docs/komodo-defi-framework/api/legacy/my_recent_swaps/#response-success , we can even add filters for specific...

@mariocynicys can you please fix failing docker tests compilation by running this command `cargo test --test 'docker_tests_main' --features run-docker-tests` and checking the errors. You can wait for https://github.com/KomodoPlatform/komodo-defi-framework/pull/1960 to be...

@mariocynicys As discussed, we should also implement `P2PK` outputs spending in this PR. You should wait for the merge of the conflicting PR first for this too.