letswritecode icon indicating copy to clipboard operation
letswritecode copied to clipboard

Electron apps outdated

Open Spriithy opened this issue 10 years ago • 7 comments

Hey ! Just to let you know that your way of doing things with electron is already outdated ! There are imperative arguments to : electron-packager such as --platform=, --arch= and --version=.

That means, your source code doesn't compile anymore !

@TheophileDano

Spriithy avatar Jun 05 '15 14:06 Spriithy

Dang! I knew that would happen but didn't think so soon. Thanks for the heads up!

The good news is everything is versioned so the example here should hopefully still work. Please let me know if it doesn't.

shama avatar Jun 05 '15 16:06 shama

You should have a look a TideSDK by the way. It is way easier to be honest. And thanks fort replying

Le ven. 5 juin 2015 18:15, Kyle Robinson Young [email protected] a écrit :

Dang! I knew that would happen but didn't think so soon. Thanks for the heads up!

The good news is everything is versioned so the example here https://github.com/shama/letswritecode/tree/master/packaging-distributing-electron-apps should hopefully still work. Please let me know if it doesn't.

— Reply to this email directly or view it on GitHub https://github.com/shama/letswritecode/issues/3#issuecomment-109347986.

Spriithy avatar Jun 05 '15 22:06 Spriithy

Ah interesting, thanks for letting know about TideSDK!

shama avatar Jun 06 '15 00:06 shama

Haha if you ever need something about it let me know

Le sam. 6 juin 2015 02:00, Kyle Robinson Young [email protected] a écrit :

Ah interesting, thanks for letting know about TideSDK!

— Reply to this email directly or view it on GitHub https://github.com/shama/letswritecode/issues/3#issuecomment-109486185.

Spriithy avatar Jun 06 '15 10:06 Spriithy

Well after a quick review of your code in this sample, this shouldn't work. I've just cloned it, try to run it using the new electron version. Well that's what i used to say, doesn't work ;)

Spriithy avatar Jun 06 '15 14:06 Spriithy

Thanks! I added an annotation to the video indicating that electron-packager >= 4.0.0 now requires the platform, arch, and version options.

shama avatar Jun 06 '15 19:06 shama

Sounds great ! But I was wondering, when I type electron-packager ./ app_name --platform=darwin --arch=x86 --version=0.27.2, the app will just launch the Electron default app... I guess I'm doing it wrong.

Spriithy avatar Jun 06 '15 20:06 Spriithy