Said Abou-Hallawa

Results 22 comments of Said Abou-Hallawa

What does `TextCluster` really represent? Is `TextMetrics` the right place to clusterize the text? `TextMetrics` is just metrics for a string. Making `TextMetrics.getTextClusters()` return `sequence` where each `TextCluster` has `DOMString`...

I still have a problem with this proposal for two reasons: 1. You are adding to a `TextAnalyzer` to `TextMetrics` which is tied to the selected font. `TextClusters` are more...

WebKit added support for external SVG resources for `filter` and `mask`. And for `clip-path` we have this bug https://bugs.webkit.org/show_bug.cgi?id=104442. This allows referencing SVG resources from HTML elements through CSS. I...

We (the WebKit team) opposed the Canvas filter API at the beginning because we thought it is an expensive operation to be applied to every single drawing command. And we...

> Is WebKit changing stance on this? Will WebKit support global `context.filter = ...` for individual draw calls, as your third example suggests? > Yes. `context.filter = ...` API was...

> This is a great news for browser interoperability! The inconsistencies you noted were there because the `ctx.filter` state wasn't supported by Safari and the original agreement was to propose...

> Is this no longer a concern? I think without implementing the layers we already have a problem. The drop-shadow can be applied by two different ways: 1. Shadow properties...

@karlcow I added support for OffscreenCanvas filters here https://github.com/WebKit/WebKit/pull/30074.

We do not support `CanvasFilter` object. So these tests should be skipped.