react_on_rails icon indicating copy to clipboard operation
react_on_rails copied to clipboard

Published 20 hours ago • verified publisher icon shakacode

Enable StrictMode everywhere in spec/dummy

Open alexeyr-ci1 opened this issue 2 years ago • 4 comments

See https://reactjs.org/docs/strict-mode.html. This should help detect more bugs in RoR.

alexeyr-ci1 avatar Jun 27 '22 11:06 alexeyr-ci1

@alexeyr-ci1 SGTM

justin808 avatar Jul 06 '22 08:07 justin808

@justin808 After #1463 to avoid doing the work twice, StrictMode added some more restrictions in React 18.

alexeyr-ci1 avatar Jul 06 '22 09:07 alexeyr-ci1

... StrictMode added some more restrictions in React 18.

In bad way? Anything particular apart from twice rendering which is deliberate?

May you please elaborate on this? @alexeyr-ci1

ahangarha avatar Oct 27 '22 09:10 ahangarha

In bad way? Anything particular apart from twice rendering which is deliberate?

No, in a good way which catches more errors, which is what we want StrictMode for.

alexeyr-ci1 avatar Oct 27 '22 11:10 alexeyr-ci1