react-webpack-rails-tutorial icon indicating copy to clipboard operation
react-webpack-rails-tutorial copied to clipboard

Upgrade to Bootstrap 5. Closes #238

Open vtamara opened this issue 2 years ago • 4 comments

  • Replaces bootstrap-loader with Bootstrap 5 loaded directly with shakapacker
  • Updates navigation bar to Bootstrap 5 and changes presentation to make it somehow similar to the Bootstrap 3 version
  • Upgrades react-bootstrap to a version that handles Bootstrap 5 and adjusts css
  • Footer improved minimally

After this PR, more work is needed in transition from one demo to another (e.g From "React Router" to "Classic"). With this PR the transition redraws full page without style and after applies style, and it is noticeable but it was not noticeable with Bootstrap 3.


This change is Reviewable

vtamara avatar Mar 27 '22 14:03 vtamara

https://user-images.githubusercontent.com/701221/160287805-be0071ed-eeef-4cb1-9f63-214642869261.mp4

vtamara avatar Mar 27 '22 15:03 vtamara

Nice work.

Is this PR ready to merge?

Reviewed 15 of 15 files at r1, all commit messages. Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @vtamara)

client/app/bundles/comments/components/CommentBox/CommentForm/CommentForm.jsx, line 103 at r1 (raw file):

    let ref;
    switch (+this.state.formMode) {

what does this plus do?

IMHO it is ready to merge.

The plus converts from string to integer in case that this.state.formMode is string (for some reason it was string in my case).

vtamara avatar Mar 28 '22 13:03 vtamara

@Judahmeek merge?

justin808 avatar Apr 18 '22 09:04 justin808

@vaukalak Please review and merge if CI is passing.

justin808 avatar Sep 15 '22 08:09 justin808

@ahangarha @Judahmeek I think it's worth considering merging this.

justin808 avatar Mar 15 '23 03:03 justin808

@vtamara Would you update your PR and resolve conflicts and CI failures?

ahangarha avatar Mar 17 '23 07:03 ahangarha

@justin808 Is this still wanted?

ahangarha avatar Jun 11 '23 18:06 ahangarha

see #528

justin808 avatar Jul 04 '23 19:07 justin808