react-webpack-rails-tutorial icon indicating copy to clipboard operation
react-webpack-rails-tutorial copied to clipboard

Add example of bucklescript to this tutorial

Open justin808 opened this issue 5 years ago • 11 comments

See https://github.com/shakacode/bs-react-on-rails.

I'd like to see another tab that shows Reason ML.

image

justin808 avatar Aug 09 '18 17:08 justin808

I will give it a shot. Just letting you know that I am working on it.

coderhs avatar Jan 04 '19 14:01 coderhs

@coderhs Any update?

justin808 avatar Jan 11 '19 02:01 justin808

Hi @justin808 ! I would like to grab this issue.

Sirbuland avatar Feb 22 '19 13:02 Sirbuland

@justin808 added a new tab. Please provide me permissions to push changes. Thanks!

screenshot 2019-02-22 at 7 04 38 pm

Sirbuland avatar Feb 22 '19 13:02 Sirbuland

@Sirbuland just push a PR.

justin808 avatar Feb 26 '19 05:02 justin808

@justin808 Could u please give me access. I have added the 'Reason ML' link added on top navigation bar pointing to https://reasonml.github.io. I want to create pull request. Thanks

shahidjutt72 avatar May 13 '19 18:05 shahidjutt72

@Sirbuland @shahidjutt72 The way to do this is to fork and submit a PR.

And @Sirbuland, the link would point to a demo of using Reason with the rest of the code, not to the Reason docs.

justin808 avatar May 14 '19 04:05 justin808

Hello! Is anyone working this, @justin808 ?

acald-creator avatar Jul 23 '20 20:07 acald-creator

@pullmana8, nope not right now! Want to give it a shot?

justin808 avatar Jul 24 '20 08:07 justin808

@justin808 Yes I would love to.

acald-creator avatar Jul 24 '20 13:07 acald-creator

Hi @justin808, I grabbed the issue and created a pull request #487. Please let me know if it is working. Thank you.

Reason ML Navigation Bar

Reason ML Nav Bar

hansleykowlessur avatar Feb 11 '21 10:02 hansleykowlessur

@justin808 Do you still want this? If so, what was the issue with the PR?

ahangarha avatar Aug 02 '23 19:08 ahangarha

Nice to have example of ReScript here. However, we need to check @alex35mil first.

justin808 avatar Aug 03 '23 02:08 justin808

I just want to make it clear. We want a page demonstrating components using ReScript. If I am right, there is another question. I know ReactOnRails supports ReScript. Does ReactRails support ReScript? If not, this feature conflicts with #503

ahangarha avatar Aug 04 '23 09:08 ahangarha

Added in #552

ahangarha avatar Nov 25 '23 12:11 ahangarha