react-webpack-rails-tutorial icon indicating copy to clipboard operation
react-webpack-rails-tutorial copied to clipboard

Remove application_static from docs due to Webpacker changes

Open justin808 opened this issue 6 years ago • 10 comments

Per this search:

https://github.com/shakacode/react-webpack-rails-tutorial/search?utf8=%E2%9C%93&q=application_static&type=

This needs cleanup.

justin808 avatar Jul 15 '17 23:07 justin808

Hey I'd like to help out with this if I could, seems simple enough.

rnice01 avatar Jul 22 '17 00:07 rnice01

@rnice01 Please start on this! I'll mark this taken by you, but you have only a few days to show progress. Get in touch if you want a Slack invite as well. And we need to update the docs for https://github.com/shakacode/react_on_rails.

justin808 avatar Jul 22 '17 01:07 justin808

@justin808 I'll pick this up

ramrudra avatar Aug 26 '18 18:08 ramrudra

@justin808 I would like to take this.

singhvaibhavram avatar Aug 27 '18 06:08 singhvaibhavram

@singhvaibhavram Sure. If we can get proper HMR working as well, that would be great.

justin808 avatar Aug 27 '18 07:08 justin808

@justin808 @singhvaibhavram PR #446 is for this specific issue.

ramrudra avatar Aug 27 '18 07:08 ramrudra

Yup. Will try that too. Give me a day to get me acquainted with the project and then will do that.!!

On Mon, Aug 27, 2018, 12:49 PM Justin Gordon [email protected] wrote:

@singhvaibhavram https://github.com/singhvaibhavram Sure. If we can get proper HMR working as well, that would be great.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/shakacode/react-webpack-rails-tutorial/issues/407#issuecomment-416137668, or mute the thread https://github.com/notifications/unsubscribe-auth/AM1RoXClUDp8iOZsskR0SwVsivsnZE44ks5uU518gaJpZM4OZKAN .

singhvaibhavram avatar Aug 27 '18 07:08 singhvaibhavram

@ramrudra can you msg me on slack? I have to ask you something regarding the pull request you made. slack email: [email protected]

singhvaibhavram avatar Aug 27 '18 10:08 singhvaibhavram

@justin808 I have messaged you on slack for some doubts.

singhvaibhavram avatar Aug 27 '18 10:08 singhvaibhavram

@singhvaibhavram Sure.

@justin808 Could you please send me a slack invite on [email protected]

ramrudra avatar Aug 27 '18 14:08 ramrudra