react-webpack-rails-tutorial icon indicating copy to clipboard operation
react-webpack-rails-tutorial copied to clipboard

Need to make mobile responsive

Open justin808 opened this issue 7 years ago • 15 comments

We need to make this example mobile responsive.

Any takers?

justin808 avatar Jun 24 '17 14:06 justin808

I'd be interested in taking a crack at it.

tfantina avatar Sep 01 '17 23:09 tfantina

That would be awesome. I'll mark you as the owner of this. I look forward to seeing your PR.

justin808 avatar Sep 02 '17 09:09 justin808

@tfantina you only get 1 week to be the owner and show progress.

justin808 avatar Sep 02 '17 09:09 justin808

@justin808 Hey I haven't done anything with webpacker_lite, every time I try to launch the local server I get this error:

WebpackerLite can't find the manifest file: /path/react-webpack-rails-tutorial/public/webpack/development/manifest.json
        Possible causes:
          1. You have not invoked webpack.
          2. You have misconfigured WebpackerLite's config/webpacker_lite.yml file.
          3. Your Webpack configuration is not creating a manifest.

I'm not sure what sort of additional configuration is needed in the yml file, I've also installed the webpack-manifest-plugin but I'm not sure how to proceed, although I am still really interested in this and I think I can make the example responsive I don't have a lot of experience with react_on_rails or webpacker_lite.

tfantina avatar Sep 04 '17 23:09 tfantina

I've been messing with this for several days and I just can't get it working. I will continue to do so when I have more time if not for this for my own curiosity but for the time being, I'm very sorry, I don't think I'll be able to give the pull request in time.

tfantina avatar Sep 08 '17 13:09 tfantina

@tfantina rebase on top of master...I've updated to React on Rails 9.0.

justin808 avatar Sep 09 '17 01:09 justin808

@justin808, I built a responsive app on top of a forked version of this tutorial. It has gotten a little behind this repo, it isn't using Webpacker yet, and I have been waiting to update it, hoping to hold onto hot reloading : ).

It uses flexbox and media queries, with some site-wide SCSS mixins handling the responsiveness to keep things dry. It wasn't easy to build, since I had to remove Bootstrap to get responsive flexbox to work.

It is really a different app with its own client/app/bundles, but a lot heavier on design, typography, svg graphics, and that kind of thing.

If you think it would be a good idea, this approach could be applied to make your app responsive. It could be rolled in as a "no-Bootstrap" branch (assuming it is impossible to make flexbox work properly with Bootstrap in place).

reconstructions avatar Nov 21 '17 15:11 reconstructions

@reconstructions I'm open to considering this!

justin808 avatar Nov 22 '17 03:11 justin808

@reconstructions Please send me an email [email protected].

justin808 avatar Nov 22 '17 03:11 justin808

I m willing to take this on!

mradeybee avatar Feb 20 '19 11:02 mradeybee

@justin808 I will take care this issue. Since this is using bootstrap, it seems like it is already responsive. Do you have any special design? Or if I make this app look good, is it ok?

dreamsoftech avatar Apr 23 '19 01:04 dreamsoftech

If this issue is still available, I would like to grab it as part of my application process.

Trip4077 avatar May 25 '19 20:05 Trip4077

@justin808 I have the fix for this from my own project, can I take this issue?

KnoxMajor avatar Apr 29 '22 13:04 KnoxMajor

@KnoxMajor that would be awesome! Sorry for the slow reply!

justin808 avatar Jun 06 '22 09:06 justin808

right on, @justin808 I'll take it

KnoxMajor avatar Jun 07 '22 20:06 KnoxMajor

This project is responsive now.

ahangarha avatar Aug 02 '23 18:08 ahangarha