react-webpack-rails-tutorial Upgrade to Bootstrap 4, including example of font-awesome-loader

Upgrade to Bootstrap 4, including example of font-awesome-loader

Open justin808 opened this issue 8 years ago • 9 comments

Once this gets merged: https://github.com/shakacode/bootstrap-loader/pull/56

Then we can create a branch to update from Bootstrap 3 to Bootstrap 4.

We should also show an example of using font-awesome with the font-awesome-loader.

Feb 28 '16 17:02 justin808

@justin808 Hi, I wanted to take a jab at this one. Can I take this up ?

Jun 15 '16 14:06 abhishekbose87

@abhishekbose87 Sure!

Jun 15 '16 18:06 justin808

@justin808 I got the build to pass. Now I am trying to get the design as much as possible as the previous one. But there are some issues which are cropping up (which I think will be fixed with the beta release) For eg. http://stackoverflow.com/questions/33486653/stacked-collapsible-navbar-in-bootstrap-4

Please advise whether I should go ahead with custom fixes for such issues.

Jun 17 '16 10:06 abhishekbose87

I'm open to that. Let's make a PR and I'll try it out!

Jun 17 '16 19:06 justin808

Let's get this updated, now that https://github.com/shakacode/bootstrap-loader is updated.

Aug 09 '18 18:08 justin808

Hi. I am grabbing this one as the next step of my application.