re-formality icon indicating copy to clipboard operation
re-formality copied to clipboard

Slow build time when exceeding 20 fields in form

Open gv-sothebys-ivar opened this issue 3 years ago • 2 comments

Hi,

I'm using Re-Formality version 4.0.0.-beta-17 and noticed when exceeding more than 20 fields the build times goes up exponentially. In my project I need up to 50 fields and for that case it just doesn't even build.

I created a fresh project to test this, I only have one file implementing a simple form hook and added 20 fields to input, output and validate. I then added one field at a time to see the build time of the test project was growing and this was the result when reaching 25 fields:

image

Any idea why this is happening? I have used formality from earlier versions from you guys and I haven't had any problem with large forms before 🤔

I have added the test project as a zip so you can test this out for yourself re-formality-test.zip

gv-sothebys-ivar avatar May 24 '22 16:05 gv-sothebys-ivar

Hi @gv-sothebys-ivar, thanks for the report. The earlier version was implemented without involving code generation, and the current one is a ppx.

That's unfortunate, but I won't be able to invest in this issue right now. Mainly due to being busy with relocation and the uncertainty of the future of PPXs in ReScript.

Let's review this in a couple of months.

alex35mil avatar Jul 13 '22 10:07 alex35mil

We've also had to skip this library due to the PPX taking too long to do code gen.

studious avatar Apr 02 '23 22:04 studious