fix(DASH): Fix MPD Patch when SegmentTemplate is shared between Representations

[tykus160]

Fixes #7214

[shaka-bot]

Incremental code coverage: 97.78%

[avelad]

After talking to @tykus160 , it still can't be merged because there is an error in the compiled build.

[wilsonluniz-harmonicinc]

Just curious if I can get a live version of this PR for test? So that I don't need to setup my HTTPS server.

[wilsonluniz-harmonicinc]

@tykus160 Seems only <add/> works. I tested neither <remove/> or <replace/> works.

In practice, MPD:

<S d="1" t="0" />
<S d="2" t="1" />
<S d="1" t="3" />

Remove patch:

<remove sel="/MPD/Period[@id='1']/AdaptationSet[1]/SegmentTemplate/SegmentTimeline/S[t='3']">
</remove>

Replace patch:

 <replace sel="/MPD/Period[@id='1']/AdaptationSet[1]/SegmentTemplate/SegmentTimeline/S[t='3']/@r">
    3
</replace>

Error message:

Expected _class2({ startTime: 3, endTime: 4, trueEndTime: 4, ... }) to equal _class2({ startTime: 3, endTime: 6, trueEndTime: 6, ... }).

[tykus160]

@wilsonluniz-harmonicinc I think issues you've mentioned might happen also when SegmentTemplate is not shared between Representations. Could you confirm it? If so, they will be handled in separate PRs.

[wilsonluniz-harmonicinc]

@tykus160 Oh yes you're right. Both <replace> and <remove> not works even I put <SegmentTemplate> into <Representation> and change @sel respectively. Should I open another issue for that?

[avelad]

@tykus160 Oh yes you're right. Both <replace> and <remove> not works even I put <SegmentTemplate> into <Representation> and change @sel respectively. Should I open another issue for that?

Yes please!

[tykus160]

@wilsonluniz-harmonicinc you can, it will make tracking of that easier.