shaka-player icon indicating copy to clipboard operation
shaka-player copied to clipboard

fix: fixed the Wrong caption icon (including demo) #4358

Open kartikeyshaurya opened this issue 2 years ago • 5 comments

fix: Fixed minor bug #4358 Part of #4358 fixed the code Type of change

  • [x] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] This change requires a documentation update

Checklist:

  • [x] I have signed the Google CLA https://cla.developers.google.com/
  • [x] My code follows the style guidelines of this project
  • [ ] I have made corresponding changes to the documentation
  • [x] I have verified my change on multiple browsers on different platforms
  • [x] I have run ./build/all.py and the build passes
  • [x] I have run ./build/test.py and all tests pass

Reviewed-by: @anshgo01yal Refs: #4358

kartikeyshaurya avatar Aug 02 '22 16:08 kartikeyshaurya

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Aug 02 '22 16:08 google-cla[bot]

Please revert your changes to the build-and-test workflow

And/or rebase.

joeyparrish avatar Aug 04 '22 19:08 joeyparrish

@joeyparrish
I have made the Changes according to which you asked and also there is no Fails linter/compiler checks . Kindly look into it , as per above failing issue , i think there is drive issue in the testing tool image

kartikeyshaurya avatar Aug 04 '22 19:08 kartikeyshaurya

I'm not referring to the test failure. We have some known flakiness in our tests/infra.

Please look here: https://github.com/shaka-project/shaka-player/pull/4384/files#diff-a551b322da0f9fe92abd1ec41e43c58dc5d138c0000430395e66f0c581387cd2

You have changes to a build workflow in your commit for some reason. Can you please revert those or rebase to main or both?

joeyparrish avatar Aug 04 '22 21:08 joeyparrish

@joeyparrish can you review it? Thanks!

avelad avatar Aug 09 '22 19:08 avelad