shaka-player icon indicating copy to clipboard operation
shaka-player copied to clipboard

VTT regions are not correctly implemented

Open joeyparrish opened this issue 4 years ago • 1 comments

Have you read the FAQ and checked for duplicate open issues? Yes

What version of Shaka Player are you using? master

Can you reproduce the issue with our latest release version? yes

Can you reproduce the issue with the latest code from master? yes

Are you using the demo app or your own custom app? demo

What browser and OS are you using? ChromeOS 81 stable

What are the manifest and license server URIs? Don't have test content for this yet

Looking closely at cue rendering, we use viewportAnchor{X,Y}, but not regionAnchor{X,Y}. It seems that regionAnchor attributes are only set for VTT, not TTML, but our renderer doesn't use them ever.

The VTT spec says that viewportAnchor is the position in the viewport where the region anchor is attached, and that regionAnchor is the position in the region where the region anchor attaches to the viewportAnchor.

Meanwhile, in TTML, we assign the location of the region's origin to viewportAnchor.

So we're not using all the VTT information, and we're using the attributes to mean something slightly different for TTML.

joeyparrish avatar May 20 '20 20:05 joeyparrish