shaka-player icon indicating copy to clipboard operation
shaka-player copied to clipboard

Add text style support to SimpleTextDisplayer

Open joeyparrish opened this issue 7 years ago • 3 comments

We are not currently extracting style information from subtitle formats. We also do not manipulate CSS from the default text displayer.

We could extract this information into shaka.text.Cue and pass it to the text displayer. The default displayer could then programatically style ::cue to set the appropriate properties.

joeyparrish avatar Feb 09 '18 21:02 joeyparrish

We do extract some style info. Shaka Cue has background color, color, font weight, family, style and size properties as well as line height and wrap option.

Currently our default text displayer doesn't use this info, so we can certainly work on that.

ismena avatar Feb 12 '18 16:02 ismena

I stand corrected. Thanks!

joeyparrish avatar Feb 12 '18 17:02 joeyparrish

Yes, yes, please add this!

toschlog avatar Aug 24 '22 21:08 toschlog

We already support <b>, <i>, <u> tags and colors.

We are closing this issue, if anyone is interested in supporting more styles, please open an issue with the specific details.

Thanks!

avelad avatar Feb 09 '23 11:02 avelad