FreeCAD_SheetMetal
FreeCAD_SheetMetal copied to clipboard
shaise
DWG Review: Create Base Shape Panel
This function already have a task panel. comments are appreciated:
note that there is no need for an apply button as every change in the fields of the panel are interactively shown on the part.
My remarks: maybe add an option without a bend. Just to be able to create a flat sheet without the need for a sketch. Also both tools seem to be called base shape (both issues have the exact same name @sliptonic) https://github.com/shaise/FreeCAD_SheetMetal/issues/328 Maybe this tool should keep the base shape name (or something like default/standard presets) and the other could be renamed to Convert to Sheet as it converts wires or closed sketches to a sheet.
Also, currently you create the feature and need the property editor to change parameters. For all the issues and task dialogs, the idea is that you can double click on the feature in the tree and that same dialog opens and you can adjust the features in the task dialog and save changes.
Yes. This is already the way base shape is done now. Double clicking on it in the tree reopens it and let you make changes.
I'm ok with the dropdown, they are descriptive and I think images would be too small on the dropdown scale for such complicated shaped (e.g. hat). Plus it's interactive so you can just change it and see the result.
Ok not going to open a new ticket for this but would you be so kind to turn the grid of Qpushbuttons in a grid of Qradiobuttons, that would be waaaaaaaaaay better? IT causes issues with Minimum width of Qpushbuttons that was recommended to me, to set in the stylesheets.
