FreeCAD_FastenersWB icon indicating copy to clipboard operation
FreeCAD_FastenersWB copied to clipboard
verified publisher icon shaise

Changing the workbench license

Open prokoudine opened this issue 2 years ago • 55 comments

The Workbench Creation guide recommends licensing addons under the terms of LGPL2.1 — the same license that FreeCAD source code is available under. The recommendation’s rationale is that it should be possible to ship a FreeCAD distribution, either upstream, or a custom one, with 3rd-party addons that are considered useful. While a workbench developer is free to choose an alternative license, doing so may impact the long-term viability and use of the workbench and should be considered carefully.

Ondsel would like to integrate the Fasteners workbench into its distribution of FreeCAD, because the company’s market study suggests that this feature is expected to be available in 3D CAD programs by default. We want to provide our end-users the best possible experience. There’s a possibility that this workbench then will go back to become part of upstream FreeCAD. However neither the upstream version of FreeCAD, nor Ondsel’s version of FreeCAD can distribute this workbench as long as it’s licensed under the terms of GPL2.

We are asking for a conversation about relicensing this workbench under LGPL2+ or another compatible license to allow wider distribution.

  • [X] @shaise
  • [X] @alexneufeld
  • [X] @riqueenz
  • [ ] @FreeCAD-Tools
  • [X] @luzpaz
  • [X] @hasecilu
  • [x] @berberic2
  • [X] @Roy-043
  • [ ] @EA32
  • [x] @elysium31
  • [X] @kaktusus
  • [X] @wavexx
  • [X] @tobiasfalk
  • [X] @easyw
  • [X] @fra589
  • [X] @wandrewkeech
  • [X] @algtgv
  • [X] @hpbmo
  • [X] @chennes
  • [X] @ApexArray
  • [X] @JohanAR
  • [x] @elf128
  • [X] @chrido
  • [X] @spike77453
  • [X] @yorikvanhavre
  • [X] @f3nix

prokoudine avatar Dec 05 '23 19:12 prokoudine

I have no issues with the idea of doing this. Taking a quick look through the repository contributors list, I'd say there's a good chance we can get everyone to sign off on a license change to LGPL. I agree that this change fits well within the philosophy of the FreeCAD project.

For potentially useful reference: I like the approach the MPV player developers took to tackling this exact problem: https://github.com/mpv-player/mpv/issues/2033

alexneufeld avatar Dec 05 '23 19:12 alexneufeld

@alexneufeld That's a really useful reference, thank you!

prokoudine avatar Dec 05 '23 20:12 prokoudine

I'm all for re-licensing to LGPL2.1, this is also compatible with @ulrich1a screw_maker license which the original WB was based on.

shaise avatar Dec 05 '23 20:12 shaise

waiting for response of: @riqueenz, @FreeCAD-Tools, @luzpaz, @hasecilu, @berberic2, @Roy-043, @EA32, @elysium31, @kaktusus, @wavexx, @tobiasfalk, @easyw, @fra589, @wandrewkeech, @algtgv, @hpbmo, @chennes, @ApexArray, @JohanAR, @elf128, @chrido, @spike77453, @yorikvanhavre, @f3nix

shaise avatar Dec 07 '23 13:12 shaise

I've been working on the Polish translation of this cool workbench, and I don't mind changing the license. :smile:

kaktusus avatar Dec 07 '23 14:12 kaktusus

I have no objections to the LGPL2.1 license.

Roy-043 avatar Dec 07 '23 14:12 Roy-043

I have also no objections to the LGPL2.1 license.

hpbmo avatar Dec 07 '23 14:12 hpbmo

Thanks for pinging, I wouldn't have noticed otherwise. No objection to the license change!

wavexx avatar Dec 07 '23 15:12 wavexx

Hi all,
I just made an action to correct a bug linked to the evolution of Python and FreeCAD, I do not feel entitled to decide on the licensing level... Do as your wish :-) Thanks for your work!

fra589 avatar Dec 07 '23 15:12 fra589

Thanks for ping, it's nice to know that this WB could join upstream FreeCAD. I agree with the license change, I'm also in for SheetMetal WB.

hasecilu avatar Dec 07 '23 15:12 hasecilu

In my opinion, my share of contribution is rather small and do not think that I would have a saying in this. But I do not have a problem with this.

@prokoudine will there be an other Issue/Thread where one could give Suggestion of features that would be nice if they where implemented in this move to an Integrated workbench? This is since the most intelligent think to do, while moving this to FreeCAD, is to rewrite the core of this workbench in C++/Qt.

tobiasfalk avatar Dec 07 '23 16:12 tobiasfalk

@tobiasfalk I could be talking out of my arse, but I vaguely recall that @sliptonic and @shaise were in agreement that the unfolder shoud definitely be part of the core and thus be rewritten in C++. Once/if the relicensing of both WBs has green lights, there definitely should be review of both architecture, workflow, and UX/UI to come up with a sensible plan.

prokoudine avatar Dec 07 '23 16:12 prokoudine

No objection to the license change!

riqueenz avatar Dec 07 '23 16:12 riqueenz

And can either @prokoudine or @shaise make a check list with all the pinged people to make it easier to look up who already agreed?

  • [ ] A
  • [x] B
  • [ ] ....

tobiasfalk avatar Dec 07 '23 16:12 tobiasfalk

(Copy the main post)

- [X] @shaise
- [X] @alexneufeld
- [X] @riqueenz
- [ ] @FreeCAD-Tools
- [ ] @luzpaz
- [X] @hasecilu
- [ ] @berberic2
- [X] @Roy-043
- [ ] @EA32
- [ ] @elysium31
- [X] @kaktusus
- [X] @wavexx
- [X] @tobiasfalk
- [ ] @easyw
- [X] @fra589
- [ ] @wandrewkeech
- [ ] @algtgv
- [X] @hpbmo
- [ ] @chennes
- [ ] @ApexArray
- [ ] @JohanAR
- [ ] @elf128
- [ ] @chrido
- [ ] @spike77453
- [ ] @yorikvanhavre
- [ ] @f3nix

hasecilu avatar Dec 07 '23 16:12 hasecilu

@hasecilu, Thanks! great idea!

shaise avatar Dec 07 '23 16:12 shaise

Works for me! :+1:

spike77453 avatar Dec 07 '23 16:12 spike77453

No objections here 👍

On Thu, Dec 7, 2023 at 9:35 AM spike77453 @.***> wrote:

Works for me! 👍

— Reply to this email directly, view it on GitHub https://github.com/shaise/FreeCAD_FastenersWB/issues/307#issuecomment-1845666702, or unsubscribe https://github.com/notifications/unsubscribe-auth/AV3VF6XLO7EWJU7BVXKGTQDYIHV6BAVCNFSM6AAAAABAIGPZR6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNBVGY3DMNZQGI . You are receiving this because you were mentioned.Message ID: @.***>

ApexArray avatar Dec 07 '23 16:12 ApexArray

I do not mind the change. Cheers, Mateusz

f3nix avatar Dec 07 '23 16:12 f3nix

No objection to the license change!

algtgv avatar Dec 07 '23 16:12 algtgv

No objection to the license change (and I think distributing this with FreeCAD would be a good idea :) )

chennes avatar Dec 07 '23 18:12 chennes

No objections to the license change :+1:

chrido avatar Dec 07 '23 20:12 chrido

No objections, I'm barely a contributor to this project anyway :)

JohanAR avatar Dec 08 '23 07:12 JohanAR

No objections.

JMG1 avatar Dec 08 '23 14:12 JMG1

No objection

luzpaz avatar Dec 08 '23 19:12 luzpaz

That is O.K. for me.

berberic2 avatar Dec 10 '23 17:12 berberic2

Sorry to be late :sweat_smile: I agree!

yorikvanhavre avatar Dec 11 '23 08:12 yorikvanhavre

go for it! sorry being late, but I don't watch very often my GH notifications

easyw avatar Dec 15 '23 20:12 easyw

FYIO: What git blame thinks about the missing user. This is not a comprehensive analysis!

EA32 419 lines in 18 files
    GrammaticalTools.py:25
    InitGui.py:1
    FsData/gost1144head.csv:42
    FsData/gost1144length.csv:2
    FsData/gost1144range.csv:2
    FsFunctions/FSmakeWoodScrew.py:104
    Icons/ASMEB18.2.1.6.svg:14
    Icons/ASMEB18.21.1.12B.svg:11
    Icons/ASMEB18.3.5C.svg:12
    Icons/DIN508.svg:26
    Icons/GN507.svg:49
    Icons/GOST1144-3.svg:33
    Icons/GOST1144-4.svg:33
    Icons/ISO4014.svg:14
    Icons/ISO4028.svg:12
    Icons/ISO7089.svg:11
    Icons/ThreadedRod.svg:14
    Icons/ThreadedRodInch.svg:14

FreeCAD-Tools 1922 lines in 34 files
    TRANSLATIONS.md:73
    GrammaticalTools.py:41
    FastenerBase.py:29
    FastenersCmd.py:35
    README.md:4
    ScrewMaker.py:2
    translations/fasteners_pt-br.ts:182
    translations/fasteners_pt-pt.ts:182
    translations/fasteners_ru.qm:39
    translations/fasteners_ru.ts:885
    translations/update.sh:43
    translations/fasteners_es-ar.ts:137
    translations/fasteners_es-es.ts:137
    FsData/DiaList.csv:2
    FsData/din571length.csv:19
    FsData/gost1144length.csv:29
    FsData/gost1144range.csv:22
    FsData/gost11860def.csv:15
    FsFunctions/FSmakeCupNut.py:1
    FsFunctions/FSmakeWoodScrew.py:1
    Icons/ASMEB18.3.1A.svg:17
    Icons/ASMEB18.3.5A.svg:11
    Icons/ASMEB18.3.5B.svg:11
    Icons/ASMEB18.5.2.svg:13
    Icons/DIN96.svg:16
    Icons/GOST1144-1.svg:19
    Icons/GOST1144-2.svg:19
    Icons/GOST11860-1.svg:12
    Icons/ISO4026.svg:11
    Icons/ISO4027.svg:11
    Icons/ISO4762.svg:16
    Icons/PCBSpacer.svg:17

elysium31 0 lines in 0 files 0

wandrewkeech 0 lines in 0 files

elf128 0 lines in 0 files

berberic2 avatar Dec 23 '23 13:12 berberic2

Hey, sorry for late replly. I'm ok with the change.

Dec 7, 2023 08:44:44 Shai Seger @.***>:

waiting for response of: @riqueenz[https://github.com/riqueenz], @FreeCAD-Tools[https://github.com/FreeCAD-Tools], @luzpaz[https://github.com/luzpaz], @hasecilu[https://github.com/hasecilu], @berberic2[https://github.com/berberic2], @Roy-043[https://github.com/Roy-043], @EA32[https://github.com/EA32], @elysium31[https://github.com/elysium31], @kaktusus[https://github.com/kaktusus], @wavexx[https://github.com/wavexx], @tobiasfalk[https://github.com/tobiasfalk], @easyw[https://github.com/easyw], @fra589[https://github.com/fra589], @wandrewkeech[https://github.com/wandrewkeech], @algtgv[https://github.com/algtgv], @hpbmo[https://github.com/hpbmo], @chennes[https://github.com/chennes], @ApexArray[https://github.com/ApexArray], @JohanAR[https://github.com/JohanAR], @elf128[https://github.com/elf128], @chrido[https://github.com/chrido], @spike77453[https://github.com/spike77453], @yorikvanhavre[https://github.com/yorikvanhavre], @f3nix[https://github.com/f3nix]

— Reply to this email directly, view it on GitHub[https://github.com/shaise/FreeCAD_FastenersWB/issues/307#issuecomment-1845368583], or unsubscribe[https://github.com/notifications/unsubscribe-auth/ABOXE3OMXSDKQPODYZO4LQTYIHB4XAVCNFSM6AAAAABAIGPZR6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNBVGM3DQNJYGM]. You are receiving this because you were mentioned. [Tracking image][https://github.com/notifications/beacon/ABOXE3NFSSEY423KIDK7KILYIHB4XA5CNFSM6AAAAABAIGPZR6WGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTTN7YLQO.gif]

elf128 avatar Dec 23 '23 14:12 elf128