facebook_page_scraper icon indicating copy to clipboard operation
facebook_page_scraper copied to clipboard

Published 20 hours ago • verified publisher icon shaikhsajid1111

better name parsing for facebook groups

Open lrudolph333 opened this issue 1 year ago • 5 comments

Hey this is an issue I resolved and would like to commit to your open-source project.

Right now your package only groups the first user name on a given facebook page. This is fine for pages but terrible for groups, which always have many posts from many users.

I added support for grabbing the author names from every post in a FB group, instead of just the first author on a FB page.

Is this an open source project, or will my solution be only available to me?

lrudolph333 avatar Feb 13 '24 04:02 lrudolph333

Hi @lrudolph333, I assume you've made changes in your local copy of this repository. This project is open to changes that brings improvements. If you want to make changes to this repository from your local changes, feel free to push those changes to new branch and raise a Pull Request

shaikhsajid1111 avatar Feb 13 '24 13:02 shaikhsajid1111

Hi @lrudolph333! I've been looking for a fix for this issue as I am trying to use this project for facebook groups instead of facebook pages. I hope you can share the changes you made soon!

GabrielMunarriz avatar Feb 22 '24 06:02 GabrielMunarriz

@shaikhsajid1111 I have these changes committed locally, however I don't have permission to push or create branches on this repo. I'm getting a 403 error when I attempt either of these, who are you allowing pushes from on this repo? You may have to adjust the repo settings.

lrudolph333 avatar Mar 04 '24 01:03 lrudolph333

@lrudolph333 Others can raise PR. Can you please share how're you trying it?

shaikhsajid1111 avatar Mar 08 '24 16:03 shaikhsajid1111

Hey apologies on the delay, I just opened a PR with my changes from my forked repo. Before I was trying to merge from a branch I made off your repo.

Let me know what you think.

On Fri, Mar 8, 2024 at 8:29 AM Sajid Shaikh @.***> wrote:

@lrudolph333 https://github.com/lrudolph333 Others can raise PR. Can you please share how're you trying it?

— Reply to this email directly, view it on GitHub https://github.com/shaikhsajid1111/facebook_page_scraper/issues/95#issuecomment-1986005926, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMRS2FRA2ZNS7SXBCBMWYZDYXHRO7AVCNFSM6AAAAABDF225Z2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOBWGAYDKOJSGY . You are receiving this because you were mentioned.Message ID: @.***>

lrudolph333 avatar Mar 26 '24 05:03 lrudolph333