papercode icon indicating copy to clipboard operation
papercode copied to clipboard

Can you kindly replace git submodules with FetchContent or CPM

Open Longwater1234 opened this issue 10 months ago • 4 comments

Awesome project! I noticed you are using git submodules to fetch dependencies inside vendor Dir.

Sadly, This takes huge amounts time and disk-space because it forces user to download entire git history of each Repo.

I am kindly proposing to use Cmake built-in "fetchcontent" or CPM to instead download thin Git releases (tar.gz) for each dependency.

Also, as a bonus, it will make cloud builds or CI/CD complete faster.

Longwater1234 avatar Apr 17 '24 11:04 Longwater1234

Hi Davis! Thanks for checking my project. I really appreciate it. Sorry to say I'm not skilled enough in cmake stuffs but if you want to you can make the changes, make pull requests and I will merge it!

On Wed, Apr 17, 2024 at 5:09 PM Davis Tibbz @.***> wrote:

Awesome project! I noticed you are using git submodules to fetch dependencies inside vendor Dir.

Sadly This takes huge amounts time and disk-space because it forces user to download entire history of each Repo.

I am kindly proposing to use Cmake built-in "fetchcontent" or CPM https://github.com/cpm-cmake/cpm.cmake to instead download thin Git releases (tar.gz) for each dependency.

— Reply to this email directly, view it on GitHub https://github.com/shahfarhadreza/papercode/issues/1, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFTKQ2UXKRX7P2H55RXFZX3Y5ZJ5BAVCNFSM6AAAAABGLC3R2GVHI2DSMVQWIX3LMV43ASLTON2WKOZSGI2DQMBSGI4DQMQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>

shahfarhadreza avatar Apr 17 '24 19:04 shahfarhadreza

Make it work on linux and I will make this for you... 😀 did this for NotepadNext. Will have a look into this issue this weekend.

diegoiast avatar Apr 17 '24 20:04 diegoiast

Thanks I appreciate it.

shahfarhadreza avatar Apr 17 '24 21:04 shahfarhadreza

@elcuco Hello just checking ....did you succeed ?

Longwater1234 avatar Jun 16 '24 09:06 Longwater1234