react-native-switch icon indicating copy to clipboard operation
react-native-switch copied to clipboard

Android Switch Circle is Not Visible

Open ranvir-gorai opened this issue 7 years ago • 13 comments

In Ios ios_sw In Android android_sw

ranvir-gorai avatar Jul 15 '18 10:07 ranvir-gorai

Same here

TareqElMasriDev avatar Jul 17 '18 09:07 TareqElMasriDev

This is the case for me too, but when I put text on the control for rendering:

imagen

imagen

As you can see, the circle is cutout.

This is on Android using the master branch version of the package.

shackra avatar Jul 18 '18 07:07 shackra

Oh, seems you need to update container style and set bigger height

shahen94 avatar Jul 18 '18 20:07 shahen94

I fixed this issue in a Fork I made, test it from here and tell me if it works with you I will open a pull-request, you can install it with this command $ yarn add git+https://github.com/TareqElMasri/react-native-switch.git

TareqElMasriDev avatar Jul 19 '18 15:07 TareqElMasriDev

@TareqElMasri I think you are almost there:

imagen

imagen

shackra avatar Jul 20 '18 05:07 shackra

@shackra I will work on it and get back to you

TareqElMasriDev avatar Jul 22 '18 08:07 TareqElMasriDev

@shackra I pushed a fix for it, why don't you give it another try and tell me if it's fixed

TareqElMasriDev avatar Jul 22 '18 11:07 TareqElMasriDev

Not there yet :(

imagen

imagen

imagen

imagen

shackra avatar Jul 24 '18 03:07 shackra

To be sure, I just have to yarn add git+https://github.com/TareqElMasri/react-native-switch.git right? no need to explicitly uninstall the package and then run yarn, right?

shackra avatar Jul 24 '18 03:07 shackra

@shackra right

shahen94 avatar Jul 24 '18 09:07 shahen94

@TareqElMasri your solution worked for me

DuduOP avatar Jul 25 '18 07:07 DuduOP

@shackra I think yarn has cached my package, try installing via npm

TareqElMasriDev avatar Jul 25 '18 14:07 TareqElMasriDev