pfQuest icon indicating copy to clipboard operation
pfQuest copied to clipboard

Weird behavior after last updates

Open nonameform opened this issue 3 years ago • 17 comments

At first it seemed that there was an issue with the quests in DB, but after some time I have discovered that it is an issue in pfQuest.

WoWScrnShot_120820_122424

On this screenshot I am hovering over the mob at the center of the image. As you can see he has a silver question mark over his head. However, pfQuest draws a golden question mark on the minimap and in the tooltip you can see that I am ready to turn in The Admiral's Orders.

WoWScrnShot_120820_122427

You can see on the second screenshot that pfQuest believes that I am on that quest as it tells me to turn it in to the NPC.

WoWScrnShot_120820_122433

In my questlog I have the next quest in that chain that requires me to travel to Orgrimmar.

Then I have encountered the same problem with the quest Call of Flame, that requires me to travel to the Barrens and speak to NPC.

WoWScrnShot_120820_142533

However, pfQuest believes that I do not have that quest as demonstrated by golden exclamation mark where a question mark should be. pfQuest also believes that I am already on the next quest in the chain.

WoWScrnShot_120820_142545

But once I move into the Barrens...

WoWScrnShot_120820_142920

Apparently there is an issue with pfQuest when it comes to quests that take you to another zone.

nonameform avatar Dec 08 '20 11:12 nonameform

Did you disable the quest-log buttons? Because if not, it would mean that the quest wasn't identified properly by pfQuest. Is this Vanilla or TBC?

shagu avatar Dec 08 '20 12:12 shagu

Vanilla, buttons are disabled. It is only true for quests that have the same title. For example, Ride to Orgrimmar shows correctly that I have to go to Org.

nonameform avatar Dec 08 '20 12:12 nonameform

Similar problem as #109 it seems.

Glancing at the code for a minute, checking the Objectives field in addition to the title should take care of a lot of those ambiguities, and the ones mentioned here in particular. There are still some edge cases which have exactly the same title and objectives text, but a lot less and most of them are exclusive to each other or for different races anyway.

Muehe avatar Dec 08 '20 16:12 Muehe

I don't think it's a wrong detection of the quest. The quest detection is quite good since it checks for titles, objectives, texts, races, professions and in addition using levenshtein to find the best if there are still doubts. (https://github.com/shagu/pfQuest/blob/master/database.lua#L1366-L1432)

It's more likely to be a missing update to the questgiver symbols after completing the previous quest.

@nonameform If you have something like that next time, could you please open the map, select "Hide Quests" and then "All Quests" in the dropdown menu, this would update all nodes and would tell us if it's a repaint issue or not.

shagu avatar Dec 08 '20 17:12 shagu

Before submitting the issue I did reload the UI and even logged out of the game. As I found out later, for whatever reason pfQuest did not register that I have completed the previous quest in The Admiral's Orders chain.

Since I have not changed anything else in my WoW setup (no new addons, no changes of paths) and it was a new character with clean pfQuest right from level 1, there might be an issue in pfQuest.

If I run into that problem again, I will try using the questlog buttons.

nonameform avatar Dec 09 '20 09:12 nonameform

Before submitting the issue I did reload the UI and even logged out of the game. As I found out later, for whatever reason pfQuest did not register that I have completed the previous quest in The Admiral's Orders chain.

Thanks, this information helps a lot. :+1:

shagu avatar Dec 09 '20 10:12 shagu

Do you use any addons for quick quest turn in and auto accept new quests?

shagu avatar Dec 09 '20 10:12 shagu

Nope.

At the time I made this post I was running the following addons:

aux - AH addon BetterCharacterStats - makes stats display in the similar to TBC fashion Mail - mailbox addon Outfitter - character outfit manager SP_SwingTimer - melee swing timer pfUI pfQuest

nonameform avatar Dec 09 '20 10:12 nonameform

I wish I could help here. I tried several times, but I'm unable to reproduce it:

Youtube

shagu avatar Dec 09 '20 12:12 shagu

Look at what I have got for you.

Here I am standing at Durotar, minding my own business before moving into Orgrimmar.

WoWScrnShot_120920_153745

Then this happens.

WoWScrnShot_120920_153751

If I enable questlog buttons, it works correctly and only shows the quest in Durotar when I press Show.

I have been running that setup (no questlog buttons) for quite some time, so it was different before, I am pretty sure of it.

nonameform avatar Dec 09 '20 12:12 nonameform

I realized that the second time I had this issue it was the same story as with The Admiral's Orders: for whatever reason pfQuest did not register that I have already turned in previous Call of Fire quest. So once I changed zone to Org, it showed me a golden exclamation mark above an NPC. It is still weird, since I never had that issue before and I have been running pfQuest since Kronos 3 started, so over 2 years now.

nonameform avatar Dec 12 '20 10:12 nonameform

I have encountered the same issue (but on a different PC) at Teldrassil with Crown of the Earth questline. After I have picked up the last quest in chain, pfQuest showed me that the NPC which gave me the quest also has some other quest from the same chain available for pick up.

I am surprised that I am the only person with that problem, yet it happens on different PCs :(

nonameform avatar Feb 08 '21 09:02 nonameform

Did this happen while using the latest 6.2.2 version? Do you have any kind of "compatibility" addons running that could mess around in the Addon-API?

Since the Jan 7, 2021 there is an idle-updater that should automatically check for quest changes that haven't been painted yet and trigger a map refresh if one is found.

shagu avatar Feb 08 '21 09:02 shagu

Yes, I used the latest version of pfQuest. I am running a very minimal addon setup and all addons are compatible with 1.12, no weird stuff.

I wonder if any leftover settings from previous versions might cause that issue for me.

nonameform avatar Feb 08 '21 10:02 nonameform

I wonder if any leftover settings from previous versions might cause that issue for me.

There's no config changes that could produce that. If you ever had another character with the same name on the same realm previously, your quest journal could still include completed quests from the previous character. You could check /db journal for completed quests and verify. While questing, if you type /db debug you will see the internal actions whenever pfQuests refreshes either the quest givers or the quest nodes. This would at least give some trace when something happens again.

shagu avatar Feb 08 '21 10:02 shagu

I am running a very minimal addon setup and all addons are compatible with 1.12

I'm not talking about incompatible addons here, it's more like addons called !Compatibility and similar, that turn the 1.12 API into some weird state somewhere between 1.12 and 3.3.5a, overwrite functions, change the return values, and and and.

shagu avatar Feb 08 '21 11:02 shagu

While questing, if you type /db debug you will see the internal actions whenever pfQuests refreshes either the quest givers or the quest nodes. This would at least give some trace when something happens again.

I will try that.

I'm not talking about incompatible addons here, it's more like addons called !Compatibility and similar, that turn the 1.12 API into some weird state somewhere between 1.12 and 3.3.5a, overwrite functions, change the return values, and and and.

Nope, nothing like that.

The list is almost the same as in December:

aux - AH addon BetterCharacterStats - makes stats display in the similar to TBC fashion Mail - mailbox addon Outfitter - character outfit manager pfUI pfQuest YaHT - hunter timer addon

nonameform avatar Feb 08 '21 12:02 nonameform

This issue is stale because it has been open for 30 days with no activity.

github-actions[bot] avatar Feb 29 '24 02:02 github-actions[bot]

This issue was closed because it has been inactive for 14 days since being marked as stale.

github-actions[bot] avatar Mar 14 '24 02:03 github-actions[bot]