Sebastian Hädrich comments

Results 249 comments of


                                            Sebastian Hädrich

[4/?] Add ability to run code examples in the playground: Get pony snippets tested with ponyc at CI time

> invalid reference format > _(From https://github.com/ponylang/pony-tutorial/actions/runs/9377723825/job/25819734031?pr=551)_ Does anyone know where that comes from?

[11.x] Add multiple method signatures for where in PHPDoc block

Well, otherwise, it's impossible to know what can be passed to `where()` and how unless from experience, since the method signature is incredibly complex. How would you achieve that instead?...

[12.x] Add enum functionality to morph map

I'm not sure why [static analysis / Types (pull_request)](https://github.com/laravel/framework/actions/runs/15694416596/job/44216493281?pr=56057) failed. I can't seem to find how this is related to my changes.

[11.x] Introduce `OnQueue` and `OnConnection` attributes for jobs, Mailables, Notifications, queued event listeners

An `On` prefix makes me think, it's an event listener. `In` would sound more naturally to me.

[11.x] Introduce `OnQueue` and `OnConnection` attributes for jobs, Mailables, Notifications, queued event listeners

I see, touché 😂👍🏻

[11.x] Introduce `OnQueue` and `OnConnection` attributes for jobs, Mailables, Notifications, queued event listeners

> Yet another way to slow down the framework. If you want super fast, maybe, you shouldn't use Laravel in the first place 🙄

[12.x] Add findRand() method to Eloquent Builder for random record selection

At the risk of being smart-alecky here: Is it really "finding" (or "searching" to begin with) something if we say "give me whatever"? That being said (or asked to be...

Add QueryException message handling without replacing bindings.

> ```php >

Add QueryException message handling without replacing bindings.

> Thank you for review! > > How about the following name? > > * `hide_bindings_on_exception_message` > * `hide_bindings_on_error_message` > * `hide_parameters_on_exception_message` > * `hide_parameters_on_error_message` There's also `mask_{bindings|parameters}_on_{error|exception}_message`. I'd say,...

[12.x] Add a Custom for `AsFluent` Cast Implementation

Your description might be off. It looks like you are adding `AsFluent` case, which has already been added in #56046. However, what your code actually does, is adding a `using()`...