next-pwa icon indicating copy to clipboard operation
next-pwa copied to clipboard

Published 20 hours ago • verified publisher icon shadowwalker

Introduce an `enableOffline` configuration flag

Open aboodman opened this issue 4 years ago • 3 comments

Introduce an enableOffline configuration flag that controls whether offline features work. Defaults to false in dev mode, true in production.

Addresses #143

aboodman avatar Jan 25 '21 10:01 aboodman

Thanks for the pull request. This is something I was trying to avoid initially as it adds complexity. For offline, you can simply verify it works using yarn start instead of yarn dev. Once offline is working, it's working. During the development mode, most caching rules are disabled to avoid noise when developing other service worker features, such as web push. You will keep online during development mode anyway since hot reloading needs that to work. Please feel free to argue a scenario where full offline is a must during development.

shadowwalker avatar Feb 05 '21 04:02 shadowwalker

This PR is stale, right? @shadowwalker Do you mind adding this to the backlog or something? I recommend you close this PR if it's not a backlog or something to implement.

ImBIOS avatar Nov 09 '22 11:11 ImBIOS

@aboodman It seems this repo is dead and the maintainer cannot be contacted for so long now. I've made an immediate response by resurrecting this repo ImBIOS/next-pwa.

ImBIOS avatar May 02 '23 03:05 ImBIOS