Woody Gilk comments

Results 117 comments of


                                            Woody Gilk

`AbstractProvider::getParsedResponse` should always return array or throw exception

I'm open to additional PR(s) to improve the behavior.

`AbstractProvider::getParsedResponse` should always return array or throw exception

The correct solution would be for `UnexpectedValueException` to set the `$previous` attribute on the exception, so that you could do: ```php try { $response = $provider->getResponse($request); } catch (UnexpectedValueException $e)...

Renaming a function does not account for existing log groups

The function identified as `CronEligibility` was previously named `cron-eligibility`.

Renaming a function does not account for existing log groups

Note that this is not the `name` attribute, but the object key for the function.

Renaming a function does not account for existing log groups

I don't really understand all of that, but shouldn't it be as simple as the framework looking to see if the log group exists before trying to create a new...

Transfer ownership?

Actually I've been actively working on https://github.com/Im0rtality/Underscore which is becoming quite decent.

Transfer ownership?

@bluesnowman fphp-saber really isn't comparable to underscore at all.

Enum instances aren't singletons

What would be the point of singletons? Enums are [value objects](https://en.wikipedia.org/wiki/Value_object) and value objects equality is not based on identity: > a value object is a small object that represents...

Enum instances aren't singletons

@KartaviK see [my response above](#issuecomment-386769803). Enums (as implemented in this package) are value objects, and value objects have equality by state, not by being singletons.

Dependency Injection / Code Decoupling

More careful analysis is needed to clearly identify where injections need to happen. If anyone has started research on this, please post your notes here so that effort is not...