ros_ethercat icon indicating copy to clipboard operation
ros_ethercat copied to clipboard

Use a SwitchControllerRequest object instead of python argument mapping

Open guihomework opened this issue 5 years ago • 0 comments

Proposed changes

Using a SwitchControllerRequest object instead of python argument mapping to a request object. This permits to be more "forward" compatible in case of future API changes that would break the current call if new parameters would be added (or changed place)

Types of changes

What types of changes does your code introduce?

  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [X] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. This is a reminder of what we should look for before merging this code. I have:

  • [X] Read and follow the contributing guidelines.
  • [X] Checked that all tests pass with my changes
  • [ ] Added tests (automatic or manual) that prove the fix is effective or that the feature works
  • [ ] Added necessary documentation (if appropriate)
  • [ ] Added the corresponding license to each file and add the current year of any one that you modified.
  • [X] Tested on real hardware (if appropriate)

guihomework avatar Feb 14 '20 17:02 guihomework