slang icon indicating copy to clipboard operation
slang copied to clipboard
verified publisher icon shader-slang

Allow Link time constant array length sizing, warn on unsupported functionality

Open expipiplus1 opened this issue 7 months ago • 7 comments

expipiplus1 avatar May 12 '25 14:05 expipiplus1

/format

expipiplus1 avatar May 12 '25 14:05 expipiplus1

🌈 Formatted, please merge the changes from this PR

slangbot avatar May 12 '25 14:05 slangbot

Falcor test is breaking?

csyonghe avatar May 14 '25 06:05 csyonghe

We should also test declaring link time constants inside a namespace and a __included file.

csyonghe avatar May 26 '25 17:05 csyonghe

We now warn instead of segfaulting on link time constant sized arrays, however the reflection API is still incomplete, we can tackle this in a follow up PR

expipiplus1 avatar Jun 10 '25 10:06 expipiplus1

We should add more test cases here.

  • reflection test TEST:REFLECTION
  • thread local array: static int a[link_time_const];
  • group shared array

kaizhangNV avatar Jun 25 '25 03:06 kaizhangNV

I'm OK with the change itself.

kaizhangNV avatar Jun 25 '25 03:06 kaizhangNV