slang icon indicating copy to clipboard operation
slang copied to clipboard

PR gets stuck when there are only document changes

Open jkwak-work opened this issue 1 year ago • 3 comments

When PR has only document files changed, the CI gets stuck. "build"-s are not supposed to be triggered but they are. I am not sure if it related to the recent change with "licence/cla" action.

image

jkwak-work avatar Nov 26 '24 22:11 jkwak-work

Two examples can be found here:

  • https://github.com/shader-slang/slang/pull/5659
  • https://github.com/shader-slang/slang/pull/5672

jkwak-work avatar Nov 26 '24 22:11 jkwak-work

It is because that CI ignores changes restricted to the docs directory, this is safe to ignore. Or we can unconditionally run such workflows

expipiplus1 avatar Nov 28 '24 07:11 expipiplus1

Why does the build workflows are triggered in the first place? The label checking workflow seems to be doing fine as expected in a way that it is not triggered at all. They seem to have the same path-ignore settings.

jkwak-work avatar Nov 28 '24 07:11 jkwak-work

The tests are showing up because the repo is configured to expect these tests to pass, when in fact they are not triggered. This is just a github display issue, and no tests are actually stuck.

csyonghe avatar Dec 02 '24 18:12 csyonghe

See https://github.com/shader-slang/slang/settings/branch_protection_rules/1102224 under "Require status checks to pass before merging"

csyonghe avatar Dec 02 '24 18:12 csyonghe