rtl-styling icon indicating copy to clipboard operation
rtl-styling copied to clipboard

Toggle Switches

Open ffoodd opened this issue 4 years ago • 2 comments

Hi there, me again <3

In the (almost done!) RTL PR in Bootstrap, toggle switches got opposite reviews: after some researches I managed to gather a few references and screenshots to reach a conclusion (comment in PR) but since it's been quite discussed, I think it could be a good candidate for RTL Styling 101.

Moreover, do you agree with my conclusion that Toggle Switches should flip in RTL?

Thanks again for this awesome tool.

ffoodd avatar Sep 07 '20 09:09 ffoodd

Hello @ffoodd,

Thanks again for the continuous support and help for RTL Styling 101! That means a lot to me. I must admit that I'm a bit busy these days with my job and releasing the book. I hope that I will get some time soon for it as I have lots of ideas and updates to add.

Now to your question, I agree that toggle switches should be flipped in RTL. I did a quick research and found the following from Firefox OS in Arabic

header-standard

So, yes, toggle switches should flip for RTL 😃

shadeed avatar Sep 07 '20 15:09 shadeed

Thanks, keep going 😉

ffoodd avatar Sep 07 '20 16:09 ffoodd

I'm embarrassed that it's been over 3 years since this issue was created, but at least I closed it today. Thanks a lot for suggesting it. Fixed in the last commit.

shadeed avatar Nov 22 '23 20:11 shadeed