ui icon indicating copy to clipboard operation
ui copied to clipboard

Component Dialog can be refactored so we can use Dialog.Root, Dialog.Content etc...

Open stephyswe opened this issue 2 years ago • 0 comments

Here's a refactored version "Dialog.tsx" Just an example how to keep the "." method.

// Re-usable Component Wrapper, example

// component-wrapper.ts

import * as React from "react";

import { cn } from "@/lib/utils";

type ComponentOrElement =
  | keyof JSX.IntrinsicElements
  | React.JSXElementConstructor<any>;

interface ComponentProps extends React.ComponentProps<any> {
  className?: string;
}

function onComponent<P extends ComponentProps>(
  component: ComponentOrElement,
  defaultClassName: string,
  displayName?: string
) {
  const ForwardedComponent = React.forwardRef<unknown, P>(
    ({ className, ...props }, ref) =>
      React.createElement(component as string | React.ComponentType<any>, {
        ref,
        className: cn(defaultClassName, className),
        ...props,
      })
  );

  ForwardedComponent.displayName = displayName;

  return ForwardedComponent;
}

export default onComponent;

dialog.tsx

import * as DialogPrimitive from "@radix-ui/react-dialog";

import onComponent from "./component-wrapper";

const defaultClasses = {
  overlay:
    "fixed inset-0 z-50 bg-background/80 backdrop-blur-sm data-[state=open]:animate-in data-[state=closed]:animate-out data-[state=closed]:fade-out-0 data-[state=open]:fade-in-0",
  content:
    "fixed left-[50%] top-[50%] z-50 grid w-full max-w-lg translate-x-[-50%] translate-y-[-50%] gap-4 border bg-background p-6 shadow-lg duration-200 data-[state=open]:animate-in data-[state=closed]:animate-out data-[state=closed]:fade-out-0 data-[state=open]:fade-in-0 data-[state=closed]:zoom-out-95 data-[state=open]:zoom-in-95 data-[state=closed]:slide-out-to-left-1/2 data-[state=closed]:slide-out-to-top-[48%] data-[state=open]:slide-in-from-left-1/2 data-[state=open]:slide-in-from-top-[48%] sm:rounded-lg md:w-full",
  header: "flex flex-col space-y-1.5 text-center sm:text-left",
  footer: "flex flex-col-reverse sm:flex-row sm:justify-end sm:space-x-2",
  title: "text-lg font-semibold leading-none tracking-tight",
  description: "text-sm text-muted-foreground",
};

const { Root, Trigger, Portal, Overlay, Content, Title, Description } =
  DialogPrimitive;

const Dialog = {
  Root,
  Trigger,
  Portal,
  Overlay: onComponent(Overlay, defaultClasses.overlay, "DialogOverlay"),
  Content: onComponent(Content, defaultClasses.content, "DialogContent"),
  Header: onComponent("div", defaultClasses.header),
  Footer: onComponent("div", defaultClasses.footer),
  Title: onComponent(Title, defaultClasses.title, "DialogTitle"),
  Description: onComponent(
    Description,
    defaultClasses.description,
    "DialogDescription"
  ),
};

export { Dialog };

Then we can use it as following.

"use client";

import { Dialog } from "@/components/ui/dialog";

interface ModalProps {
  title: string;
  description: string;
  isOpen: boolean;
  onClose: () => void;
  children?: React.ReactNode;
}

export const Modal: React.FC<ModalProps> = ({
  title,
  description,
  isOpen,
  onClose,
  children,
}) => {
  const onChange = (open: boolean) => {
    if (!open) {
      onClose();
    }
  };

  return (
    <Dialog.Root open={isOpen} onOpenChange={onChange}>
      <Dialog.Content>
        <Dialog.Header>
          <Dialog.Title>{title}</Dialog.Title>
          <Dialog.Description>{description}</Dialog.Description>
        </Dialog.Header>
        <div>{children}</div>
      </Dialog.Content>
    </Dialog.Root>
  );
};

As radix already use the "." method, it seems smarter to keep that?

stephyswe avatar Jul 02 '23 06:07 stephyswe