ui icon indicating copy to clipboard operation
ui copied to clipboard

fix(alert): update icon postion in alert

Open FathyMuhamed opened this issue 2 years ago • 5 comments

before image

after image

FathyMuhamed avatar Jun 29 '23 20:06 FathyMuhamed

@FathyMuhamed is attempting to deploy a commit to the shadcn-pro Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Jun 29 '23 20:06 vercel[bot]

This wouldn't fix the issue. I explain the problem with Firefox in this issue #627.

If you want to fix this you can make these changes in the alert.tsx file (remember to update both styles):

const alertVariants = cva(
- "relative w-full rounded-lg border p-4 [&:has(svg)]:pl-11 [&>svg+div]:translate-y-[-3px] [&>svg]:absolute [&>svg]:left-4 [&>svg]:top-4 [&>svg]:text-foreground",
+ "relative w-full rounded-lg border p-4 [&>svg+div]:translate-y-[-3px] [&>svg]:absolute [&>svg]:left-4 [&>svg]:top-4 [&>svg]:text-foreground [&>svg~*]:pl-7",

After changing both files you need to build the registry by running:

pnpm build:registry

(Thanks to @adham-coding for the hint)

dan5py avatar Jun 29 '23 21:06 dan5py

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
next-template ⬜️ Ignored (Inspect) Jun 30, 2023 6:40pm

vercel[bot] avatar Jun 30 '23 14:06 vercel[bot]

Be careful. You have updated only one of the themes and once you built the registry also files that you haven't changed got updated (I assume you're on Windows). Also don't update the pnpm-lock.yaml please.

dan5py avatar Jun 30 '23 14:06 dan5py

@dan5py thanks for the guidance

FathyMuhamed avatar Jun 30 '23 14:06 FathyMuhamed