ui icon indicating copy to clipboard operation
ui copied to clipboard

fix(tailwind-prefix): resolve prefixing issue for Tailwind CSS v4 compatibility (including tests)

Open Joshua-hypt opened this issue 10 months ago • 8 comments

Extension of #6688

  • Updated tests
  • Added backwards compatibility for tailwind v3

Fixes: #6687

Joshua-hypt avatar Mar 07 '25 13:03 Joshua-hypt

@Joshua-hypt is attempting to deploy a commit to the shadcn-pro Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Mar 07 '25 13:03 vercel[bot]

also what's the case for people using tailwind v3 ? we need to take into consideration this, as this is a breaking change for them. cc @shadcn

azizChebbi avatar Mar 07 '25 14:03 azizChebbi

also what's the case for people using tailwind v3 ? we need to take into consideration this, as this is a breaking change for them. cc @shadcn

@azizChebbi I added backwards compatibility for tw v3 now.

@shadcn not sure what function applyPrefixesCss still has, I think it can be deleted?

Joshua-hypt avatar Mar 08 '25 20:03 Joshua-hypt

@shadcn can we merge this?

Joshua-hypt avatar Mar 31 '25 11:03 Joshua-hypt

@shadcn what's missing in this PR ? we really need this in our migration project, as we are using tailwind v4 but the shadcn components are missing the new prefix syntax. please let's try to merge this one if nothing is blocking

azizChebbi avatar Apr 01 '25 21:04 azizChebbi

+1 on this

sonomandeep avatar Apr 04 '25 18:04 sonomandeep

@shadcn this is still pending, could you find the time to take a look at this please?

Joshua-hypt avatar Apr 22 '25 14:04 Joshua-hypt

@shadcn review this pls

josuedantas7 avatar Apr 24 '25 18:04 josuedantas7

can we get this in before gta 6 release? 🙏

changyeamoon avatar May 08 '25 03:05 changyeamoon

Fixes #7175 as well; adding a comment for better issue linking.

psullivan6 avatar May 18 '25 17:05 psullivan6

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
ui ✅ Ready (Inspect) Visit Preview May 19, 2025 7:27am
v4 ✅ Ready (Inspect) Visit Preview May 19, 2025 7:27am

vercel[bot] avatar May 19 '25 07:05 vercel[bot]