ui icon indicating copy to clipboard operation
ui copied to clipboard

fix(cli): detect vinxi-based frameworks (@tanstack/start, SolidStart, ...)

Open KitsuneDev opened this issue 1 year ago • 2 comments

This PR adds CLI support for vinxi-based projects, such as @tanstack/start and Solid Start.

Thanks to the fact that those projects are essentially Vite projects, not many changes were necessary, and adding the app.config.* to the detection logic is all that was really necessary. Just to be on the safe side, I also added a simple check that the said file does contain a defineConfig string (and is actually a Vinxi-based config), as the name app.config.* tends to be quite generic.

This has been tested in a barebones @tanstack/start project, and the result can be viewed here. Each commit represents a step of the setup process, following the instructions from the docs.

KitsuneDev avatar Jan 11 '25 17:01 KitsuneDev

@KitsuneDev is attempting to deploy a commit to the shadcn-pro Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Jan 11 '25 17:01 vercel[bot]

@KitsuneDev Let's fix the conflicts. I'll review and merge. Thank you

shadcn avatar Mar 12 '25 17:03 shadcn

We merged a PR to detect TanStack Start using dependencies (see https://github.com/shadcn-ui/ui/blob/b8fede1742ae34150e1dd244160834100fefac12/packages/shadcn/src/utils/get-project-info.ts#L122) but I like the solution here since it works with any vinxi-based framework.

I'll fix and merge. Thank you.

shadcn avatar Jul 01 '25 11:07 shadcn

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
ui ⬜️ Ignored (Inspect) Jul 1, 2025 0:57am

vercel[bot] avatar Jul 01 '25 12:07 vercel[bot]