ui icon indicating copy to clipboard operation
ui copied to clipboard

Combobox does not remove error message

Open pinticli opened this issue 2 years ago • 3 comments

Hi - I noticed that the Combobox component does not clear the error message after the selection of an item. To replicate this:

1.- Go to the component page, "React Hook" section: https://ui.shadcn.com/docs/components/combobox#react-hook-form 2.- Click on Submit to trigger the error message. 3.- Select an item. 4.- Error message is still present until you hot Submit again.

For the rest of the form components, the error messages are effectively removed after the user input passes field validation.

pinticli avatar Jun 09 '23 21:06 pinticli

Hi, i would like to submit a pull request to fix this.

JuanPedroPontVerges avatar Jun 09 '23 21:06 JuanPedroPontVerges

Hi! Is this issue still open? I would like to work on it.

  • And one thing i would like to mention is that if we select any item from the list the dropdown still remains open until we click somewhere outside of the dropdown menu.

SurajAnand88 avatar Jun 14 '23 15:06 SurajAnand88

@SurajAnand88 A PR for this issue has already been submitted (#568, and it seems fine). Check the issue #588 for the problem you pointed out.

dan5py avatar Jun 14 '23 16:06 dan5py

I have fixed here https://github.com/shadcn-ui/ui/issues/2944#issuecomment-2151796269

vienpt avatar Jun 06 '24 09:06 vienpt

This issue has been automatically closed because it received no activity for a while. If you think it was closed by accident, please leave a comment. Thank you.

shadcn avatar Jun 29 '24 23:06 shadcn