ui icon indicating copy to clipboard operation
ui copied to clipboard

feat: remove clsx library and utilize cx feature from cva library

Open Gabriel-Traldi opened this issue 2 years ago • 4 comments

Within CVA, they already utilize CLSX and export it as 'cx', eliminating the need for separate installation and allowing for direct usage of the same feature from CVA.

image

image

Gabriel-Traldi avatar Jun 02 '23 15:06 Gabriel-Traldi

@Gabriel-Traldi is attempting to deploy a commit to the shadcn-pro Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Jun 02 '23 15:06 vercel[bot]

Interesting. Let me look into it.

shadcn avatar Jun 02 '23 17:06 shadcn

Interesting. Let me look into it.

I think it's not the right time yet. In the next version of cva, tw-merge will be integrated, and then we will only need one library, cva. I believe that will be the time for change.

yorunning avatar Jun 03 '23 08:06 yorunning

I believe @yorunning is referencing https://github.com/joe-bell/cva/discussions/141#discussioncomment-6196281. Here, it was mentioned that users will have the option to extend cx with tailwind-merge. Unless I'm mistaken, this likely means that tailwind-merge will have to be installed separately alongside cva, just like how it's installed currently.

Also, even in the @cva/tailwindcss package, tailwind-merge seems to be listed as a peer dependency. In the installation instructions for this package, tailwind-merge is installed separately. Regardless, I think it would be convenient to have this merged sooner than later, as the tailwind-merge change won't make it into cva until version 1.0.

ap-1 avatar Jun 29 '23 13:06 ap-1