ui icon indicating copy to clipboard operation
ui copied to clipboard

fix(toast): local variable name shadows variable in outer scope (see line 140)

Open jgengo opened this issue 2 years ago • 3 comments

Hello 👋🏻

I propose this very tiny PR that corrects a local variable name that shadows a variable in the outer scope.

On L.96, toast is used in the forEach, knowing that toast is already a named function on L140.

It is very tiny and makes sense in terms of readability to keep toast if you feel like so feel free to disregard and close this PR.

Best regards,

jgengo avatar Jun 01 '23 09:06 jgengo

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
next-template ⬜️ Ignored (Inspect) Jun 1, 2023 9:02am

vercel[bot] avatar Jun 01 '23 09:06 vercel[bot]

@jgengo is attempting to deploy a commit to the shadcn-pro Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Jun 01 '23 09:06 vercel[bot]

Probably would be great to add https://eslint.org/docs/latest/rules/no-shadow for fixing this kind of rules

its-monotype avatar Jun 01 '23 15:06 its-monotype

Is there a reason for this PR to still be open?

Do you want me to do something special on that, or should I just close it?

jgengo avatar Aug 25 '23 18:08 jgengo