ui icon indicating copy to clipboard operation
ui copied to clipboard

feat: Enhanced Tailwind support inside CVA and cn

Open ap-1 opened this issue 2 years ago • 7 comments

This snippet inside of settings.json allows the Tailwind CSS extension to provide intellisense for the strings inside CVA. It has no effect if the Tailwind CSS extension is not installed, but I believe many of shadcn/ui's users already do. The same has been done for the cn() helper.

I also added a few more changes:

  • The Tailwind CSS extension is now in the "recommendations" field in .vscode/extensions.json.
  • There are now instructions to install the Tailwind CSS extension inside a new "Editor setup" docs page.
  • cva is now in the list of callees in the eslint-plugin-tailwindcss settings.

ap-1 avatar May 24 '23 13:05 ap-1

@ap-1 is attempting to deploy a commit to the shadcn-pro Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar May 24 '23 13:05 vercel[bot]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
next-template ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 29, 2023 0:38am

vercel[bot] avatar May 24 '23 14:05 vercel[bot]

https://github.com/francoismassart/eslint-plugin-tailwindcss/blob/master/docs/rules/classnames-order.md#callees-default-classnames-clsx-ctl-cva-tv

its-monotype avatar Jun 02 '23 04:06 its-monotype

And do not use "prettier-plugin-tailwindcss" and "eslint-plugin-tailwindcss" simultaneously, it can cause unreal lags in VSCode

its-monotype avatar Jun 02 '23 04:06 its-monotype

Depending on how #528 is implemented, we might require a couple changes here

ap-1 avatar Jun 09 '23 19:06 ap-1

⚠️ No Changeset found

Latest commit: af87571c84d0381e7408e98b40d9e063f378b432

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Jun 29 '23 12:06 changeset-bot[bot]

Relevant: https://github.com/joe-bell/cva/discussions/85#discussioncomment-5014769

ap-1 avatar Jun 29 '23 12:06 ap-1