ui
ui copied to clipboard
fix(docs): added missing `CommandList` to combobox docs
I think this PR can fixed: #3732, #3707, #809, #3012, #3637
@neighborhood999 is attempting to deploy a commit to the shadcn-pro Team on Vercel.
A member of the Team first needs to authorize it.
I think that this need cmdk == 1.0.0
https://github.com/pacocoursey/cmdk/releases/tag/v1.0.0
Please replace data-[disabled]
classes with aria-disabled
for CommandPrimitive.Item
as well. Other changes may be required per cmdk@v1
but that was the only issue I encountered.
Hi @ezeparziale and @mpourismaiel,
Thanks for reminding me, I applied your guys' suggestions.
Stumbled upon the same issue and fix independently today, was crashing local development. Good to see a fix and hope it gets merged soon 👍
Hey @shadcn, can you help to verify this PR : )?
@neighborhood999 There are some conflicts and the checks are not passing, I doubt it will be reviewed while that's the case.
@neighborhood999 I believe this is fixed now. Going to close this as fixed. Feel free to reopen if not. Appreciate your help.
Google Chrome Version 127.0.6533.89 (Official Build) (64-bit)
shadcn @.***> schrieb am Mo., 5. Aug. 2024, 12:23:
@neighborhood999 https://github.com/neighborhood999 I believe this is fixed now. Going to close this as fixed. Feel free to reopen if not. Appreciate your help.
— Reply to this email directly, view it on GitHub https://github.com/shadcn-ui/ui/pull/3431#issuecomment-2268726288, or unsubscribe https://github.com/notifications/unsubscribe-auth/BIO77CIOIFSMXSNJQQ75QLDZP5HBZAVCNFSM6AAAAABF57N4JGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENRYG4ZDMMRYHA . You are receiving this because you are subscribed to this thread.Message ID: @.***>