fix: update cmdk breaking changes

[ObjectJosh]

Overview

cmdk v1.0.0 released some breaking changes This PR fixes @shadcn's usage of cmdk's Command component for the shadcn Combobox component.

• Updated cmdk v0.2.1 -> v1.0.0
• Fixed new selector of data-[selected=true] (see release notes above)
• Wrapped CommandItems in a CommandList (see release notes above)

Fixes #3213 #3051 #3047 #3024 #3021 #3012 #2944 #3256

Before:

After running npx shadcn-ui@latest add combobox there is a breaking change incompatibility:

Only wrapping in CommandList fixes the above error, but it's defaulted to disabled (unclickable):

After:

⭐ Adding both fixes, works as expected!

[vercel[bot]]

@ObjectJosh is attempting to deploy a commit to the shadcn-pro Team on Vercel.

A member of the Team first needs to authorize it.

[capaj]

thanks you @ObjectJosh. Tried your proposed changes on my little project, works nicely for my usecase.

[coolbaluk]

👋

Thanks for making the changes! Any movement on this PR ?

[ObjectJosh]

👋

Thanks for making the changes! Any movement on this PR ?

@coolbaluk Currently waiting for it to get merged. Not sure if the proposed changes above by @darrenswhite ar e correct. Would like a second opinion, thanks.

[shadcn]

Fixed in https://github.com/shadcn-ui/ui/pull/2626. (also a duplicate of https://github.com/shadcn-ui/ui/pull/2945). If not, feel free to re-open. Thank you.

[nullnullsieben]

5013

shadcn @.***> schrieb am Mo., 5. Aug. 2024, 12:22:

Closed #3268 https://github.com/shadcn-ui/ui/pull/3268.

— Reply to this email directly, view it on GitHub https://github.com/shadcn-ui/ui/pull/3268#event-13762021457, or unsubscribe https://github.com/notifications/unsubscribe-auth/BIO77COUUYPFIKLZDPEGARDZP5G7TAVCNFSM6AAAAABFPAOUBSVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJTG43DEMBSGE2DKNY . You are receiving this because you are subscribed to this thread.Message ID: @.***>