ui icon indicating copy to clipboard operation
ui copied to clipboard

[Bug]: unable to reset the text input values using rect-hook-form

Open saravanakumarputta opened this issue 11 months ago • 4 comments

Describe the bug

Am using, react hook forma long with text input components as shown in the form example. On a case I need to reset the field values and i use form.reset() and it didn't work.

Affected component/components

Form, Inout

How to reproduce

I followed the example given here https://ui.shadcn.com/docs/components/input#form

Codesandbox/StackBlitz link

No response

Logs

No response

System Info

Mac

Before submitting

  • [X] I've made research efforts and searched the documentation
  • [X] I've searched for existing issues

saravanakumarputta avatar Mar 21 '24 14:03 saravanakumarputta

i haven't tried. But I need this once I submit the form, I need to clear all field values. Now am manually setting all field values to default values.

saravanakumarputta avatar Mar 29 '24 12:03 saravanakumarputta

I have similar issue. Using this force refresh did the trick. But it's not pretty.

"use client";

import { zodResolver } from "@hookform/resolvers/zod";
import { useForm } from "react-hook-form";
import { z } from "zod";

import { Button } from "../../../components/ui/button";
import {
  Form,
  FormControl,
  FormDescription,
  FormField,
  FormItem,
  FormLabel,
  FormMessage,
} from "../../../components/ui/form";
import { RadioGroup, RadioGroupItem } from "../../../components/ui/radio-group";
import { useTheme } from "next-themes";
import {useEffect} from "react";

const appearanceFormSchema = z.object({
  theme: z.enum(["light", "dark", "system"], {
    required_error: "Please select a theme.",
  }),
});

type AppearanceFormValues = z.infer<typeof appearanceFormSchema>;

export function AppearanceForm() {
  const { setTheme, theme } = useTheme();
  let forceRefresh = new Date().getTime();

  const form = useForm<AppearanceFormValues>({
    resolver: zodResolver(appearanceFormSchema)
  });

  useEffect(() => {
    form.resetField('theme', {defaultValue: theme as 'light' | 'dark' | 'system' ?? 'light'});
    forceRefresh = new Date().getTime();
  }, [theme, form.reset]);

  function onSubmit(data: AppearanceFormValues) {
    setTheme(data.theme);
  }

  return (
    <Form {...form}>
      <form onSubmit={form.handleSubmit(onSubmit)} className="space-y-8">
        <FormField key={forceRefresh}
          control={form.control}
          name="theme"
          render={({ field }) => (
            <FormItem className="space-y-1">
              <FormLabel>Theme</FormLabel>
              <FormDescription>
                Select the theme for the dashboard.
              </FormDescription>
              <FormMessage />
              <RadioGroup
                onValueChange={field.onChange}
                defaultValue={field.value}
                className="grid max-w-md grid-cols-2 gap-8 pt-2"
              >
                <FormItem>
                  <FormLabel className="[&:has([data-state=checked])>div]:border-primary">
                    <FormControl>
                      <RadioGroupItem value="light" className="sr-only" />
                    </FormControl>
                    <div className="items-center rounded-md border-2 border-muted p-1 hover:border-accent">
                      <div className="space-y-2 rounded-sm bg-[#ecedef] p-2">
                        <div className="space-y-2 rounded-md bg-white p-2 shadow-sm">
                          <div className="h-2 w-[80px] rounded-lg bg-[#ecedef]" />
                          <div className="h-2 w-[100px] rounded-lg bg-[#ecedef]" />
                        </div>
                        <div className="flex items-center space-x-2 rounded-md bg-white p-2 shadow-sm">
                          <div className="h-4 w-4 rounded-full bg-[#ecedef]" />
                          <div className="h-2 w-[100px] rounded-lg bg-[#ecedef]" />
                        </div>
                        <div className="flex items-center space-x-2 rounded-md bg-white p-2 shadow-sm">
                          <div className="h-4 w-4 rounded-full bg-[#ecedef]" />
                          <div className="h-2 w-[100px] rounded-lg bg-[#ecedef]" />
                        </div>
                      </div>
                    </div>
                    <span className="block w-full p-2 text-center font-normal">
                      Light
                    </span>
                  </FormLabel>
                </FormItem>
                <FormItem>
                  <FormLabel className="[&:has([data-state=checked])>div]:border-primary">
                    <FormControl>
                      <RadioGroupItem value="dark" className="sr-only" />
                    </FormControl>
                    <div className="items-center rounded-md border-2 border-muted bg-popover p-1 hover:bg-accent hover:text-accent-foreground">
                      <div className="space-y-2 rounded-sm bg-slate-950 p-2">
                        <div className="space-y-2 rounded-md bg-slate-800 p-2 shadow-sm">
                          <div className="h-2 w-[80px] rounded-lg bg-slate-400" />
                          <div className="h-2 w-[100px] rounded-lg bg-slate-400" />
                        </div>
                        <div className="flex items-center space-x-2 rounded-md bg-slate-800 p-2 shadow-sm">
                          <div className="h-4 w-4 rounded-full bg-slate-400" />
                          <div className="h-2 w-[100px] rounded-lg bg-slate-400" />
                        </div>
                        <div className="flex items-center space-x-2 rounded-md bg-slate-800 p-2 shadow-sm">
                          <div className="h-4 w-4 rounded-full bg-slate-400" />
                          <div className="h-2 w-[100px] rounded-lg bg-slate-400" />
                        </div>
                      </div>
                    </div>
                    <span className="block w-full p-2 text-center font-normal">
                      Dark
                    </span>
                  </FormLabel>
                </FormItem>
              </RadioGroup>
            </FormItem>
          )}
        />

        <Button type="submit">Update preferences</Button>
      </form>
    </Form>
  );
}

siimsams avatar Apr 06 '24 22:04 siimsams

@saravanakumarputta can u pls provide code that help us to understand where is issue?

ruru-m07 avatar Apr 07 '24 08:04 ruru-m07

It is not a bug. It usually happens if you don't set default values in your useForm function.

You need to set default values to empty for each field to reset form.

kam-st avatar Apr 27 '24 06:04 kam-st