ui icon indicating copy to clipboard operation
ui copied to clipboard

[feat]: 🎥 Video Player Component for Shadcn UI.

Open ruru-m07 opened this issue 1 year ago • 11 comments

Feature description

Hey Shadcn UI team! 👋

I'm reaching out with a feature request that's sure to make your UI shine brighter than ever: a dedicated video player component! 📽️

Imagine being able to seamlessly embed videos into your apps and websites, giving users an immersive and engaging experience. With this component, you can:

  • [ ] Play videos from local files or URLs
  • [ ] Control playback with intuitive controls
  • [ ] Display video metadata and thumbnails
  • [ ] Customize the player's appearance to match your brand

This feature would not only enhance the user experience but also open up new possibilities for interactive and visually appealing applications. Let's make it happen together! 🤝

Thanks for considering my request. I'm excited to see how this component can transform Shadcn UI into a multimedia powerhouse! 🌟

Before submitting

  • [X] I've made research efforts and searched the documentation
  • [X] I've searched for existing issues and PRs

ruru-m07 avatar Mar 12 '24 15:03 ruru-m07

Hey there, your idea is great and I'm willing to make this video player and add it to the repository and I'm willing to be assigned to the issue so that I work on it please

AmirNBK avatar Mar 12 '24 17:03 AmirNBK

@AmirNBK u started working on it?

ruru-m07 avatar Mar 13 '24 15:03 ruru-m07

dose my idea is no good?

@shadcn

@AmirNBK

@elliot

@bjacobso

ruru-m07 avatar Mar 15 '24 14:03 ruru-m07

@AmirNBK u started working on it? No i did mean it's actually great and I wanna work on it and make a video component

AmirNBK avatar Mar 15 '24 16:03 AmirNBK

So yeah it's a great one and I think it can make Shadcn much better if you let me work on it and wanted to make sure nobody else is working on it currently

AmirNBK avatar Mar 15 '24 16:03 AmirNBK

@AmirNBK no one working on it u can start work for it.

ruru-m07 avatar Mar 16 '24 06:03 ruru-m07

sure I'm gonna start that and we'll publish it soon.

AmirNBK avatar Mar 17 '24 09:03 AmirNBK

sure I'm gonna start that and we'll publish it soon.

Actually looked it up a bit as well (because I've worked on mine for previous repos). I have used VidStack, and it's sexy in combination with shadcn/ui. It's also licensed with MIT, so I believe it might be the best option.

Feel free to give me your thoughts on this!

airone01 avatar Mar 20 '24 17:03 airone01

@AirOne01 I tried to use VidStack, but I failed. There are thousands of problems using that library. Do you have any other suggestions?

ruru-m07 avatar Mar 22 '24 15:03 ruru-m07

I don't really, but I did do a lot of crash-testing of vidstack. For example, you have to import their CSS, otherwise your component will break. All things considered, that probably is not a good thing.

airone01 avatar Mar 22 '24 15:03 airone01

@AirOne01 check this https://cookpete.github.io/react-player/

ruru-m07 avatar Mar 22 '24 15:03 ruru-m07

@shadcn can any one look at this Feature ?

ruru-m07 avatar Apr 13 '24 15:04 ruru-m07

Hey there sorry I had some work to do so I showed up late actually, I guess the best option would be that we develop the player ourselves other libraries might have some issues or bugs that cannot be standard enough

AmirNBK avatar Apr 15 '24 04:04 AmirNBK