[Input Password]: eye icon doesn't show

[fernandops26]

When you load first time a value of a input type password, the eye icon doesn't show. Following below its a selected input:

[puneet-sarhali]

The "eye icon" is not included in the default HTML input tag, and it has not been implemented in this library either. You can submit a feature request if you would like this to be implemented.

[dBianchii]

+1 to This. Maybe as a variant, instead of default

[tuminzee]

The "eye icon" is not included in the default HTML input tag, and it has not been implemented in this library either. You can submit a feature request if you would like this to be implemented.

can I try to work on this?

[tuminzee]

@multiwebinc @shadcn @puneet-sarhali have a look at this, what should be the next step here Should I implement in all the components?

[multiwebinc]

@tuminzee If it's not too much code, I would try to integrate that into https://github.com/shadcn/ui/blob/main/apps/www/components/ui/input.tsx and submit a PR. You could add the optional parameter showPasswordToggle and if the type is text, the password would be revealed by default, and if it's password, it would be hidden by default. Clicking on the icon would toggle the type between text and password.

[tuminzee]

@multiwebinc I have the code ready let me know how I can contribute

[tuminzee]

@tuminzee If it's not too much code, I would try to integrate that into https://github.com/shadcn/ui/blob/main/apps/www/components/ui/input.tsx and submit a PR. You could add the optional parameter showPasswordToggle and if the type is text, the password would be revealed by default, and if it's password, it would be hidden by default. Clicking on the icon would toggle the type between text and password.

I have done exactly that but I am tacking it down using passing the type=password

[multiwebinc]

@multiwebinc I have the code ready let me know how I can contribute

Just edit the file and submit a pull request.

[tuminzee]

perfect @multiwebinc I will create a pr by tonight thanks for the support, have a good day 🕺🏼

[tuminzee]

sorry for the delay @multiwebinc I made this PR https://github.com/shadcn/ui/pull/504 which only add the feature in the example pages, let me know where else should I add this. it should also be added to the main components ui, but I will wait for the feedback for this one thank you for being patience

[anasmohammed361]

https://github.com/shadcn-ui/ui/pull/504#issuecomment-1883379209

[shadcn]

This issue has been automatically closed because it received no activity for a while. If you think it was closed by accident, please leave a comment. Thank you.