ui icon indicating copy to clipboard operation
ui copied to clipboard

npx shadcn-ui@latest add button create wrong tailwindcss className in components because of wrong space between className

Open yinsang opened this issue 1 year ago • 0 comments

npx shadcn-ui@latest add button

create a button, source code here. This button can't be clicked.

import * as React from "react"
import { Slot } from "@radix-ui/react-slot"
import { cva, type VariantProps } from "class-variance-authority"

import { cn } from "@/lib/utils"

const buttonVariants = cva(
  " inline-flex  items-center  justify-center  whitespace-nowrap  rounded-md  text-sm  font-medium  ring-offset-background  transition-colors focus-visible: outline-none focus-visible: ring-2 focus-visible: ring-ring focus-visible: ring-offset-2 disabled: pointer-events-none disabled: opacity-50",
  {
    variants: {
      variant: {
        default: " bg-primary  text-primary-foreground hover: bg-primary/90",
        destructive:
          " bg-destructive  text-destructive-foreground hover: bg-destructive/90",
        outline:
          " border  border-input  bg-background hover: bg-accent hover: text-accent-foreground",
        secondary:
          " bg-secondary  text-secondary-foreground hover: bg-secondary/80",
        ghost: "hover: bg-accent hover: text-accent-foreground",
        link: " text-primary  underline-offset-4 hover: underline",
      },
      size: {
        default: " h-10  px-4  py-2",
        sm: " h-9  rounded-md  px-3",
        lg: " h-11  rounded-md  px-8",
        icon: " h-10  w-10",
      },
    },
    defaultVariants: {
      variant: "default",
      size: "default",
    },
  }
)

export interface ButtonProps
  extends React.ButtonHTMLAttributes<HTMLButtonElement>,
    VariantProps<typeof buttonVariants> {
  asChild?: boolean
}

const Button = React.forwardRef<HTMLButtonElement, ButtonProps>(
  ({ className, variant, size, asChild = false, ...props }, ref) => {
    const Comp = asChild ? Slot : "button"
    return (
      <Comp
        className={cn(buttonVariants({ variant, size, className }))}
        ref={ref}
        {...props}
      />
    )
  }
)
Button.displayName = "Button"

export { Button, buttonVariants }

Notice disabled: pointer-events-none is very different from disabled:pointer-events-none which has no space between disabled: and pointer-events-none project here

yarn
npx shadcn-ui@latest add button

you will see wrong className in @/components/button which has two spaces between classNames. test.zip

yinsang avatar Jan 26 '24 05:01 yinsang