ui
ui copied to clipboard
Fix: Button outline color correction
Hi everyone,
This is my first PR so let me know if I did anything wrong. Still learning the ins and outs of things but trying to be more active and notice fixes when I see them.
I made a quick fix to the <Button variant="outline">
where the background wasn't actually the right color for just an outline. The prime source of error here was when an outlined button sits inside a <Card>
object, where the button then takes the color of the background rather than the color of the Card it sits on. Switching from bg-background
to bg-inherit
handles these two issues.
Sample where bg-inherit
is used:
Sample where bg-background
is used:
Thanks everyone! I've been loving this library for my website I'm building, and can't wait to see what the final product looks like!
@thecae is attempting to deploy a commit to the shadcn-pro Team on Vercel.
A member of the Team first needs to authorize it.
Thanks for the PR (and fixes) @thecae. Could you update the PR with a more descriptive title please? Thank you.
Thanks for the PR (and fixes) @thecae. Could you update the PR with a more descriptive title please? Thank you.
Absolutely, it's fixed. Thank you for the feedback! Let me know if you want me to make any other changes.
@thecae IIRC I had this as bg-inherit
(or bg-transparent
) before but I changed it to bg-background
. Let me check and confirm why I made this change and come back to this.
(Congrats on your first PR. The first of many 🎉)