ui
ui copied to clipboard
refactor: simplified InputProps
#2316
export interface InputProps
extends React.InputHTMLAttributes<HTMLInputElement> {}
in the current codebase can be simplified to
export type InputProps = React.InputHTMLAttributes<HTMLInputElement>
this change also fixes a lint error native to the t3 stack
Someone is attempting to deploy a commit to the shadcn-pro Team on Vercel.
A member of the Team first needs to authorize it.
@shadcn Can you please review and approve this PR? This is my first open source contribution and would love to make more complex contributions in the future.
Hi @tanish-malekar, this interface is intended to be customized, that's why interface is used instead of type.
This convetion is used many times in this project.
Regarding the error in the t3 stack, you can disable the lint check with:
module.exports = {
"rules": {
"@typescript-eslint/no-empty-interface": "off"
}
};
in the .eslintrc.cjs file.