ui icon indicating copy to clipboard operation
ui copied to clipboard

refactor: simplified InputProps

Open tanish-malekar opened this issue 1 year ago • 3 comments

#2316

export interface InputProps
  extends React.InputHTMLAttributes<HTMLInputElement> {}

in the current codebase can be simplified to

export type InputProps = React.InputHTMLAttributes<HTMLInputElement> this change also fixes a lint error native to the t3 stack

tanish-malekar avatar Jan 07 '24 10:01 tanish-malekar

Someone is attempting to deploy a commit to the shadcn-pro Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Jan 07 '24 10:01 vercel[bot]

@shadcn Can you please review and approve this PR? This is my first open source contribution and would love to make more complex contributions in the future.

tanish-malekar avatar Jan 08 '24 09:01 tanish-malekar

Hi @tanish-malekar, this interface is intended to be customized, that's why interface is used instead of type. This convetion is used many times in this project.

Regarding the error in the t3 stack, you can disable the lint check with:

module.exports = {
  "rules": {
    "@typescript-eslint/no-empty-interface": "off"
  }
};

in the .eslintrc.cjs file.

dan5py avatar Jan 11 '24 16:01 dan5py