ui icon indicating copy to clipboard operation
ui copied to clipboard

dark mode button(in the vite docs) bug fix

Open keshav-nischal opened this issue 1 year ago • 1 comments

this PR fixes the issue discussed in #2237

Screencast from 03-01-24 06:18:00 PM IST.webm

For the dark mode moon icon is staying and not moving with the navbar on scrolling. For light mode everything is fine. I changed the position of button to relative so that moon icon absolute positioning use button as ancestor. this fix will make this component independent component and developers will be able to copy and paste it to there application without thinking about the positioning for the component. I am new to open source contribution, so please let me know if there's anything I can improve.

keshav-nischal avatar Jan 03 '24 12:01 keshav-nischal

@keshav-nischal is attempting to deploy a commit to the shadcn-pro Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Jan 03 '24 12:01 vercel[bot]